From owner-p4-projects@FreeBSD.ORG  Thu Jun 17 01:24:14 2004
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 3C0BE16A4D0; Thu, 17 Jun 2004 01:24:14 +0000 (GMT)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 0F17116A4CE
	for <perforce@freebsd.org>; Thu, 17 Jun 2004 01:24:14 +0000 (GMT)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 0833243D46
	for <perforce@freebsd.org>; Thu, 17 Jun 2004 01:24:14 +0000 (GMT)
	(envelope-from marcel@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5H1NusS008430
	for <perforce@freebsd.org>; Thu, 17 Jun 2004 01:23:56 GMT
	(envelope-from marcel@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5H1NuxY008427
	for perforce@freebsd.org; Thu, 17 Jun 2004 01:23:56 GMT
	(envelope-from marcel@freebsd.org)
Date: Thu, 17 Jun 2004 01:23:56 GMT
Message-Id: <200406170123.i5H1NuxY008427@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	marcel@freebsd.org using -f
From: Marcel Moolenaar <marcel@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Subject: PERFORCE change 55123 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 17 Jun 2004 01:24:15 -0000

http://perforce.freebsd.org/chv.cgi?CH=55123

Change 55123 by marcel@marcel_nfs on 2004/06/17 01:23:21

	o  The psaddr_t type is supposed to be defined in <sys/procfs.h>.
	   Move it there.
	o  Properly declare struct ps_prochandle as an opaque structure.
	   The implemention is defined by the provider of the service,
	   not in this header.
	o  Fix the prototype of ps_plog().

Affected files ...

.. //depot/projects/gdb/include/proc_service.h#2 edit
.. //depot/projects/gdb/sys/sys/procfs.h#3 edit

Differences ...

==== //depot/projects/gdb/include/proc_service.h#2 (text+ko) ====

@@ -42,11 +42,8 @@
 	PS_NOSYM		/* Symbol not found. */
 } ps_err_e;
 
-struct ps_prochandle {
-};
+struct ps_prochandle;		/* Opaque type. Defined by the implementor. */
 
-typedef void *psaddr_t;		/* An address in the target process. */
-
 __BEGIN_DECLS
 ps_err_e ps_lcontinue(struct ps_prochandle *, lwpid_t);
 ps_err_e ps_lgetfpregs(struct ps_prochandle *, lwpid_t, prfpregset_t *);
@@ -60,7 +57,7 @@
 ps_err_e ps_pdwrite(struct ps_prochandle *, psaddr_t, const void *, size_t);
 ps_err_e ps_pglobal_lookup(struct ps_prochandle *, const char *, const char *,
     psaddr_t *);
-void	 ps_plog(const char *);
+void	 ps_plog(const char *, ...);
 ps_err_e ps_pstop(struct ps_prochandle *);
 ps_err_e ps_ptread(struct ps_prochandle *, psaddr_t, void *, size_t);
 ps_err_e ps_ptwrite(struct ps_prochandle *, psaddr_t, const void *, size_t);

==== //depot/projects/gdb/sys/sys/procfs.h#3 (text+ko) ====

@@ -80,4 +80,6 @@
     char	pr_psargs[PRARGSZ+1];	/* Arguments, null terminated (1) */
 } prpsinfo_t;
 
+typedef void *psaddr_t;		/* An address in the target process. */
+
 #endif /* _SYS_PROCFS_H_ */