Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 31 May 2016 16:40:24 +0200
From:      Ed Schouten <ed@nuxi.nl>
To:        Pedro Giffuni <pfg@freebsd.org>
Cc:        Ed Schouten <ed@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r300999 - in head: include lib/libc/db/man
Message-ID:  <CABh_MKmsAKTCG%2BWRrK2U-_86xwJR3jhkVEWDOVtYBrukC6PpDQ@mail.gmail.com>
In-Reply-To: <574C7E89.3080102@FreeBSD.org>
References:  <201605301652.u4UGqNeu070540@repo.freebsd.org> <574C7E89.3080102@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
2016-05-30 19:55 GMT+02:00 Pedro Giffuni <pfg@freebsd.org>:
> IMHO, just before a new release is the perfect time to break the ABI, and
> POSIX
> is a good reason to do it.

I thought about it a bit more and switching this over to size_t will
only cause breakage on 64-bit big endian platforms. On 32-bit systems
this would have no effect. On 64-bit little endian systems, we'd still
load the bottom four bytes, which is all right. We could use symbol
versioning to deal with this, but I don't think it's worth the effort.

I've sent out a code review to both of you: https://reviews.freebsd.org/D6660

If anyone wants to share their thoughts on the proposed change, feel
free to leave a comment. I'll hold off for a couple of days before
submitting.

-- 
Ed Schouten <ed@nuxi.nl>
Nuxi, 's-Hertogenbosch, the Netherlands
KvK-nr.: 62051717



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CABh_MKmsAKTCG%2BWRrK2U-_86xwJR3jhkVEWDOVtYBrukC6PpDQ>