From owner-freebsd-bugs@FreeBSD.ORG  Thu Dec  2 08:40:11 2010
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 052E31065670
	for <freebsd-bugs@hub.freebsd.org>;
	Thu,  2 Dec 2010 08:40:11 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id BBA888FC19
	for <freebsd-bugs@hub.freebsd.org>;
	Thu,  2 Dec 2010 08:40:10 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id oB28eAIs001516
	for <freebsd-bugs@freefall.freebsd.org>; Thu, 2 Dec 2010 08:40:10 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.4/8.14.4/Submit) id oB28eATl001515;
	Thu, 2 Dec 2010 08:40:10 GMT (envelope-from gnats)
Resent-Date: Thu, 2 Dec 2010 08:40:10 GMT
Resent-Message-Id: <201012020840.oB28eATl001515@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
	Sascha Wildner <saw@online.de>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 6ECFD106566B
	for <freebsd-gnats-submit@FreeBSD.org>;
	Thu,  2 Dec 2010 08:30:31 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (unknown [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 4322A8FC0C
	for <freebsd-gnats-submit@FreeBSD.org>;
	Thu,  2 Dec 2010 08:30:31 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id oB28UUdR033358
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 2 Dec 2010 08:30:30 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id oB28UUkS033357;
	Thu, 2 Dec 2010 08:30:30 GMT (envelope-from nobody)
Message-Id: <201012020830.oB28UUkS033357@red.freebsd.org>
Date: Thu, 2 Dec 2010 08:30:30 GMT
From: Sascha Wildner <saw@online.de>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-3.1
Cc: 
Subject: kern/152768: Weird check in mfi(4)
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 02 Dec 2010 08:40:11 -0000


>Number:         152768
>Category:       kern
>Synopsis:       Weird check in mfi(4)
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Dec 02 08:40:10 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     Sascha Wildner
>Release:        none :)
>Organization:
>Environment:
>Description:
Hi there,

I recently ported FreeBSD's mfi(4) driver to DragonFly BSD and when running clang's static analyzer on the kernel, it found:

http://yoyodyne.ath.cx/tmp/scan-build-2010-12-01-1/report-tCmTHj.html#EndPath

If device is T_DIRECT (0x00) or T_PROCESSOR (0x03) then (device & 0xe0) can't be true. It kinda smells like the intention was something different here, though I'm not sure which, so I thought I'd report it.

Kind regards,
Sascha

>How-To-Repeat:

>Fix:


>Release-Note:
>Audit-Trail:
>Unformatted: