From owner-freebsd-ports@freebsd.org  Tue Jun 21 21:07:43 2016
Return-Path: <owner-freebsd-ports@freebsd.org>
Delivered-To: freebsd-ports@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 14936AC5A23
 for <freebsd-ports@mailman.ysv.freebsd.org>;
 Tue, 21 Jun 2016 21:07:43 +0000 (UTC)
 (envelope-from truckman@FreeBSD.org)
Received: from gw.catspoiler.org (unknown [IPv6:2602:304:b010:ef20::f2])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "gw.catspoiler.org", Issuer "gw.catspoiler.org" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id E88461B30
 for <freebsd-ports@freebsd.org>; Tue, 21 Jun 2016 21:07:42 +0000 (UTC)
 (envelope-from truckman@FreeBSD.org)
Received: from FreeBSD.org (mousie.catspoiler.org [192.168.101.2])
 by gw.catspoiler.org (8.15.2/8.15.2) with ESMTP id u5LL704C053301;
 Tue, 21 Jun 2016 14:07:04 -0700 (PDT)
 (envelope-from truckman@FreeBSD.org)
Message-Id: <201606212107.u5LL704C053301@gw.catspoiler.org>
Date: Tue, 21 Jun 2016 14:07:00 -0700 (PDT)
From: Don Lewis <truckman@FreeBSD.org>
Subject: Re: iozone3-434 fails to rebuild
To: jim@ohlste.in
cc: freebsd@skysmurf.nl, dougs@dawnsign.com, freebsd-ports@freebsd.org
In-Reply-To: <F5806EC6-6E07-4CAF-BDB8-5CE381DB4A8C@ohlste.in>
MIME-Version: 1.0
Content-Type: TEXT/plain; charset=us-ascii
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-ports>,
 <mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports/>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
 <mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 21 Jun 2016 21:07:43 -0000

On 21 Jun, Jim Ohlstein wrote:
> Hello,
> 
>> On Jun 21, 2016, at 4:14 PM, Alphons van Werven <freebsd@skysmurf.nl>
>> wrote:
>> 
>> Doug Sampson wrote:
>> 
>>> it crashes as follows:
>>> 
>>>  ###
>>> <...snip...>
>>> iozone.c:1297:1: error: unknown type name 'off64_t'; did you mean
>>> 'off_t'? off64_t offset = 0;               /*offset for random I/O
>>> */
>>> ^~~~~~~
>>> off_t
>>> /usr/include/sys/types.h:173:18: note: 'off_t' declared here
>>> typedef __off_t         off_t;          /* file offset */
>>>                        ^
>> [snip]
>>> Doesn't matter which config options I select/deselect,
>> 
>> As far as I can tell it doesn't *crash*, it merely fails to build ;-)
>> 
>> I don't think the options are relevant in this case. If I'm not
>> mistaken off64_t is some kind of GNU extension, but installing
>> lang/gcc and trying to compile a piece of sample code with GCC still
>> didn't work for me. Which means I can reproduce the problem on
>> 10.2-RELEASE-p19/amd64.
>> 
>> There seems to be a #define or typedef missing somewhere. Perhaps
>> somebody can ask around upstream what the authors are expecting from
>> the off64_t type, so we can find a suitable replacement on FreeBSD
>> systems: probably offset_t, (u)int64_t, or something along those
>> lines.
> 
> How about it be reverted to the previous, WORKING, version in the
> meantime, and before an "upgrade" is committed, proper testing is
> done?

The previous version didn't build on recent FreeBSD 11, which does
define off64_t.  I started trying to fix it, but the code is really
nasty and I finally gave up.