From owner-freebsd-ports  Sun Nov 14 12:30:10 1999
Delivered-To: freebsd-ports@freebsd.org
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
	by hub.freebsd.org (Postfix) with ESMTP id 2C1F4151E8
	for <freebsd-ports@FreeBSD.org>; Sun, 14 Nov 1999 12:30:06 -0800 (PST)
	(envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.9.3/8.9.2) id MAA00121;
	Sun, 14 Nov 1999 12:30:06 -0800 (PST)
	(envelope-from gnats@FreeBSD.org)
Received: from pinhead.parag.codegen.com (207-44-235-154.CodeGen.COM [207.44.235.154])
	by hub.freebsd.org (Postfix) with ESMTP id D31871506D
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 14 Nov 1999 12:21:57 -0800 (PST)
	(envelope-from parag@pinhead.parag.codegen.com)
Received: (from parag@localhost)
	by pinhead.parag.codegen.com (8.9.3/8.9.3) id MAA94257;
	Sun, 14 Nov 1999 12:21:57 -0800 (PST)
	(envelope-from parag)
Message-Id: <199911142021.MAA94257@pinhead.parag.codegen.com>
Date: Sun, 14 Nov 1999 12:21:57 -0800 (PST)
From: parag@codegen.com
Reply-To: parag@codegen.com
To: FreeBSD-gnats-submit@freebsd.org
X-Send-Pr-Version: 3.2
Subject: ports/14880: dagrab 0.3.3 port does not work under STABLE without a patch
Sender: owner-freebsd-ports@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org


>Number:         14880
>Category:       ports
>Synopsis:       dagrab 0.3.3 use of O_NONBLOCK does not work on STABLE
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Nov 14 12:30:05 PST 1999
>Closed-Date:
>Last-Modified:
>Originator:     Parag Patel
>Release:        FreeBSD 3.3-STABLE i386
>Organization:
CodeGen, Inc.
>Environment:

	FreeBSD 3.3-STABLE
	IDE CD-ROM drive
	an audio CD

>Description:

	Trying to copy an audio track from a CD using the latest 0.3.3
	port of dagrab fails to work on 3.3-STABLE.  I don't know if it
	works on CURRENT as I don't have a way to test it at the moment.

	The program fails immediately with a device-open error.  Running
	it as root makes no difference.

>How-To-Repeat:

	Try to copy an audio track using the dagrab 0.3.3 port.

>Fix:
	
	Remove the "|O_NONBLOCK" in the open() call for the CD-ROM
	device in dagrab.c.  Then it works fine for me.


*** dagrab.c-fbsd	Sat Nov 13 12:29:44 1999
--- dagrab.c	Sat Nov 13 23:00:20 1999
***************
*** 503,509 ****
  	struct ioc_toc_header Th;
  	struct ioc_read_toc_single_entry Te;
  
! 	if ((cdrom_fd=open(cd_dev,O_RDONLY|O_NONBLOCK))==-1){
  		fprintf(stderr,"%s: error opening device %s\n",progname,cd_dev);
  		exit(1);
  	}
--- 503,509 ----
  	struct ioc_toc_header Th;
  	struct ioc_read_toc_single_entry Te;
  
! 	if ((cdrom_fd=open(cd_dev,O_RDONLY))==-1){
  		fprintf(stderr,"%s: error opening device %s\n",progname,cd_dev);
  		exit(1);
  	}

>Release-Note:
>Audit-Trail:
>Unformatted:


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message