From owner-svn-ports-all@FreeBSD.ORG  Wed Nov 28 13:04:21 2012
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id 1FD9AA3F;
 Wed, 28 Nov 2012 13:04:21 +0000 (UTC)
 (envelope-from kozlov@ravenloft.kiev.ua)
Received: from ravenloft.kiev.ua (ravenloft.kiev.ua [94.244.131.95])
 by mx1.freebsd.org (Postfix) with ESMTP id CD19A8FC14;
 Wed, 28 Nov 2012 13:04:18 +0000 (UTC)
Date: Wed, 28 Nov 2012 15:04:17 +0200
From: Alex Kozlov <ak@FreeBSD.org>
To: Alexey Dokuchaev <danfe@FreeBSD.org>
Subject: Re: svn commit: r307899 - head/benchmarks/super-smack
Message-ID: <20121128130417.GA31569@ravenloft.kiev.ua>
References: <201211281109.qASB9dPm010874@svn.freebsd.org>
 <20121128115359.GA53862@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20121128115359.GA53862@FreeBSD.org>
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 28 Nov 2012 13:04:21 -0000

On Wed, Nov 28, 2012 at 11:53:59AM +0000, Alexey Dokuchaev wrote:
> On Wed, Nov 28, 2012 at 11:09:39AM +0000, Alex Kozlov wrote:
> > New Revision: 307899
> > URL: http://svnweb.freebsd.org/changeset/ports/307899
> > 
> > +PGSQL_DESC=	Enable PostgreSQL support
> > +MYSQL_DESC=	Enable MySQL support
> In this case, generic descriptions should have been used.
No, specific descriptions are still better.

> > @@ -3,4 +3,4 @@ for MySQL (and PostgreSQL). Super Smack 
> >  Pachev, and then hosted and maintained by Jeremy Zawodny.
> >  
> >  Author:	Tony Bourke <tony (at) vegan (dot) net>
> Author tag is 1) deprecated tag used only when there is no WWW found; and 2)
> badly formatted (cf. WWW).
This was impossible to catch in vim, it should be automated like with WWW.
If this tag is obsolete, then portlint should display a warning. I can
implement the patch, but before that can you please point me to documentation
where it stated? Thanks.


-- 
Alex