From owner-freebsd-current@FreeBSD.ORG  Mon Jul 11 16:53:02 2011
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C045F106566B;
	Mon, 11 Jul 2011 16:53:02 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42])
	by mx1.freebsd.org (Postfix) with ESMTP id 988908FC15;
	Mon, 11 Jul 2011 16:53:02 +0000 (UTC)
Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net
	[66.111.2.69])
	by cyrus.watson.org (Postfix) with ESMTPSA id 4EF5046B24;
	Mon, 11 Jul 2011 12:53:02 -0400 (EDT)
Received: from jhbbsd.localnet (unknown [209.249.190.124])
	by bigwig.baldwin.cx (Postfix) with ESMTPSA id E07DB8A02E;
	Mon, 11 Jul 2011 12:53:01 -0400 (EDT)
From: John Baldwin <jhb@freebsd.org>
To: Alexander Best <arundel@freebsd.org>
Date: Mon, 11 Jul 2011 12:05:13 -0400
User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110617; KDE/4.5.5; amd64; ; )
References: <201107081511.43417.jhb@freebsd.org>
	<20110709083047.GA86927@freebsd.org>
	<20110709094416.GA95093@freebsd.org>
In-Reply-To: <20110709094416.GA95093@freebsd.org>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201107111205.13178.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6
	(bigwig.baldwin.cx); Mon, 11 Jul 2011 12:53:02 -0400 (EDT)
Cc: current@freebsd.org, edwin@freebsd.org
Subject: Re: [PATCH] Make top -P an interactive toggle
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 11 Jul 2011 16:53:02 -0000

On Saturday, July 09, 2011 5:44:16 am Alexander Best wrote:
> On Sat Jul  9 11, Alexander Best wrote:
> > On Fri Jul  8 11, Alexander Best wrote:
> > > On Fri Jul  8 11, John Baldwin wrote:
> > > > This patch lets you use 'P' while top is running to toggle between per-CPU and
> > > > global CPU stats.
> > > 
> > > very cool. i always thought that being able to interactivly enable/disable
> > > per-cpu stats in top would be a useful feature. great to see this being
> > > implemented.
> > 
> > oh...and of course i tested your patch. ;) works great without any issues.
> 
> would it be possible to display a note when using 'P'? E.g. when pressing 'z'
> top informs the user with one of these messages:
> 
> "Displaying system idle process."
> 
> or
> 
> "Not displaying system idle process."
> 
> would be nice to have something similar when pressing the 'P' key. Maybe:
> 
> "Display per-cpu CPU usage statistics."
> 
> and
> 
> "Not display per-cpu CPU usage statistics."

Ok, I went with "Displaying per-CPU statistics" and
"Displaying global CPU statistics".

-- 
John Baldwin