From owner-cvs-all Wed Nov 13 10: 5:14 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EAF7637B401; Wed, 13 Nov 2002 10:05:12 -0800 (PST) Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8EB7143E4A; Wed, 13 Nov 2002 10:05:10 -0800 (PST) (envelope-from robert@fledge.watson.org) Received: from fledge.watson.org (fledge.pr.watson.org [192.0.2.3]) by fledge.watson.org (8.12.4/8.12.4) with SMTP id gADI4ROo099950; Wed, 13 Nov 2002 13:04:28 -0500 (EST) (envelope-from robert@fledge.watson.org) Date: Wed, 13 Nov 2002 13:04:26 -0500 (EST) From: Robert Watson X-Sender: robert@fledge.watson.org To: Jacques Vidrine Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libpam/modules/pam_krb5 pam_krb5.c In-Reply-To: <200211131746.gADHkF68049244@repoman.freebsd.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Does this fix the 5.0 interaction problems with Kerberos5 PAM, or are there still issues left? I've been setting up a box locally to see if I could figure out the problems, but I can give up if you think things re fixed :-). Robert N M Watson FreeBSD Core Team, TrustedBSD Projects robert@fledge.watson.org Network Associates Laboratories On Wed, 13 Nov 2002, Jacques Vidrine wrote: > nectar 2002/11/13 09:46:15 PST > > Modified files: > lib/libpam/modules/pam_krb5 pam_krb5.c > Log: > The pam_krb5 module stored a reference to a krb5_ccache structure as > PAM module state (created in pam_sm_authenticate and referenced later > in pam_sm_setcred and pam_sm_acct_mgmt). However, the krb5_ccache > structure shares some data members with the krb5_context structure > that was used in its creation. Since a new krb5_context is created > and destroyed at each PAM entry point, this inevitably caused the > krb5_ccache structure to reference free'd memory. > > Now instead of storing a pointer to the krb5_ccache structure, > we store the name of the cache (e.g. `MEMORY:0x123CACHE') in > pam_sm_authenticate, and resolve the name in the other entry points. > > This bug was uncovered by phkmalloc's free'd memory scrubbing. > > Approved by: re (jhb) > > Revision Changes Path > 1.11 +42 -20 src/lib/libpam/modules/pam_krb5/pam_krb5.c > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message