From owner-freebsd-xen@FreeBSD.ORG  Fri Jan 28 07:30:19 2011
Return-Path: <owner-freebsd-xen@FreeBSD.ORG>
Delivered-To: freebsd-xen@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 9A39A106566C
	for <freebsd-xen@hub.freebsd.org>; Fri, 28 Jan 2011 07:30:19 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 6FFE48FC1A
	for <freebsd-xen@hub.freebsd.org>; Fri, 28 Jan 2011 07:30:19 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p0S7UJvE035558
	for <freebsd-xen@freefall.freebsd.org>; Fri, 28 Jan 2011 07:30:19 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p0S7UJQv035550;
	Fri, 28 Jan 2011 07:30:19 GMT (envelope-from gnats)
Date: Fri, 28 Jan 2011 07:30:19 GMT
Message-Id: <201101280730.p0S7UJQv035550@freefall.freebsd.org>
To: freebsd-xen@FreeBSD.org
From: Janne Snabb <snabb@epipe.com>
Cc: 
Subject: Re: kern/154302: First patch is not good
X-BeenThere: freebsd-xen@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Janne Snabb <snabb@epipe.com>
List-Id: Discussion of the freebsd port to xen - implementation and usage
	<freebsd-xen.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-xen>,
	<mailto:freebsd-xen-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-xen>
List-Post: <mailto:freebsd-xen@freebsd.org>
List-Help: <mailto:freebsd-xen-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-xen>,
	<mailto:freebsd-xen-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 28 Jan 2011 07:30:19 -0000

The following reply was made to PR kern/154302; it has been noted by GNATS.

From: Janne Snabb <snabb@epipe.com>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/154302: First patch is not good
Date: Fri, 28 Jan 2011 07:26:05 +0000 (UTC)

 I wanted to add that the 1st patch I provided is not a good idea.
 
 It does not take into account that some other error than ENOENT
 could be returned.
 
 The 2nd patch is better.
 
 Alternatively it could be split to 2 separate if clauses.
 
 --
 Janne Snabb / EPIPE Communications
 snabb@epipe.com - http://epipe.com/