From owner-freebsd-ports  Tue Mar 26  1:10:15 2002
Delivered-To: freebsd-ports@hub.freebsd.org
Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id 00BEB37B419
	for <freebsd-ports@hub.freebsd.org>; Tue, 26 Mar 2002 01:10:01 -0800 (PST)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.11.6/8.11.6) id g2Q9A0r86537;
	Tue, 26 Mar 2002 01:10:00 -0800 (PST)
	(envelope-from gnats)
Received: from gongon1.gongon.com (gongon1.gongon.com [61.202.206.226])
	by hub.freebsd.org (Postfix) with ESMTP id BF31F37B427
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 26 Mar 2002 01:00:57 -0800 (PST)
Received: from gongon1.gongon.com (localhost [IPv6:::1])
	by gongon1.gongon.com (8.12.2/8.12.2) with ESMTP id g2Q90uKP056921
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 26 Mar 2002 18:00:56 +0900 (JST)
	(envelope-from iseki@gongon1.gongon.com)
Received: (from root@localhost)
	by gongon1.gongon.com (8.12.2/8.12.2/Submit) id g2Q90uEp056920;
	Tue, 26 Mar 2002 18:00:56 +0900 (JST)
	(envelope-from iseki)
Message-Id: <200203260900.g2Q90uEp056920@gongon1.gongon.com>
Date: Tue, 26 Mar 2002 18:00:56 +0900 (JST)
From: Isao SEKI <iseki@gongon.com>
Reply-To: Isao SEKI <iseki@gongon.com>
To: FreeBSD-gnats-submit@FreeBSD.org
X-Send-Pr-Version: 3.113
Subject: ports/36326: quick patch for qpopper4.0.3_1 buffer overflow
Sender: owner-freebsd-ports@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-ports.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-ports>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-ports>
X-Loop: FreeBSD.org


>Number:         36326
>Category:       ports
>Synopsis:       quick patch for qpopper4.0.3_1 buffer overflow
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    freebsd-ports
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Mar 26 01:10:00 PST 2002
>Closed-Date:
>Last-Modified:
>Originator:     Isao SEKI
>Release:        FreeBSD 4.5-RELEASE i386
>Organization:
personal
>Environment:
System: FreeBSD gongon1.gongon.com 4.5-RELEASE FreeBSD 4.5-RELEASE #1: Thu Jan 31 18:40:00 JST 2002 iseki@gongon6.gongon.com:/usr/src/sys/compile/GONGON_NOSTUN i386


>Description:
If a string of longer than approximately 2048 characters is sent to
the qpopper process, a denial of service condition will occur.

>How-To-Repeat:
Please see at the Description.

>Fix:
I have made a quick patch for qpopper4.0.3.


*** popper.c.dist	Sat Jun  2 11:24:36 2001
--- popper.c	Tue Mar 26 16:24:30 2002
***************
*** 483,489 ****
--- 483,501 ----
                  else
                      len = read ( pPOP->input_fd, junk, sizeof(junk) );
                  if ( len <= 0 )
+ #if 0
                      break;
+ #else
+                 {
+                     /*
+                      * patch by Isao SEKI <iseki@gongon.com>
+                      * return 0 is meaningless after buffer overflow
+                      */
+                     pop_log (pPOP, POP_NOTICE, HERE,
+                               "read 0 byte after buffer overflow\n");
+                     return(NULL);
+                 }
+ #endif
                  q = strchr ( junk, '\n' );
                  if ( q == NULL ) {
                      disc += len;
>Release-Note:
>Audit-Trail:
>Unformatted:

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message