From owner-svn-src-head@freebsd.org  Fri Jul 14 16:28:12 2017
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 40107DA6A24;
 Fri, 14 Jul 2017 16:28:12 +0000 (UTC)
 (envelope-from kostikbel@gmail.com)
Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id CBDC66BA1B;
 Fri, 14 Jul 2017 16:28:11 +0000 (UTC)
 (envelope-from kostikbel@gmail.com)
Received: from tom.home (kib@localhost [127.0.0.1])
 by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id v6EGS6rf018208
 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
 Fri, 14 Jul 2017 19:28:06 +0300 (EEST)
 (envelope-from kostikbel@gmail.com)
DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua v6EGS6rf018208
Received: (from kostik@localhost)
 by tom.home (8.15.2/8.15.2/Submit) id v6EGS6YP018207;
 Fri, 14 Jul 2017 19:28:06 +0300 (EEST)
 (envelope-from kostikbel@gmail.com)
X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com
 using -f
Date: Fri, 14 Jul 2017 19:28:06 +0300
From: Konstantin Belousov <kostikbel@gmail.com>
To: "Pedro F. Giffuni" <pfg@FreeBSD.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: Re: svn commit: r320990 - head/lib/libthr/thread
Message-ID: <20170714162806.GX1935@kib.kiev.ua>
References: <201707141605.v6EG5suS049499@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201707141605.v6EG5suS049499@repo.freebsd.org>
User-Agent: Mutt/1.8.3 (2017-05-23)
X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00,
 DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no
 autolearn_force=no version=3.4.1
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 14 Jul 2017 16:28:12 -0000

On Fri, Jul 14, 2017 at 04:05:54PM +0000, Pedro F. Giffuni wrote:
> Author: pfg
> Date: Fri Jul 14 16:05:54 2017
> New Revision: 320990
> URL: https://svnweb.freebsd.org/changeset/base/320990
> 
> Log:
>   libthr: 'count' is unsigned so don't check for negative values.
count is unsigned but pthread_barrier.b_count is not.
At very least, this change is half-done.

>   
>   Obtained from:	DragonFlyBSD (git e7db8139)
> 
> Modified:
>   head/lib/libthr/thread/thr_barrier.c
> 
> Modified: head/lib/libthr/thread/thr_barrier.c
> ==============================================================================
> --- head/lib/libthr/thread/thr_barrier.c	Fri Jul 14 15:42:12 2017	(r320989)
> +++ head/lib/libthr/thread/thr_barrier.c	Fri Jul 14 16:05:54 2017	(r320990)
> @@ -100,7 +100,7 @@ _pthread_barrier_init(pthread_barrier_t *barrier,
>  	pthread_barrier_t bar;
>  	int pshared;
>  
> -	if (barrier == NULL || count <= 0)
> +	if (barrier == NULL || count == 0)
>  		return (EINVAL);
>  
>  	if (attr == NULL || *attr == NULL ||