From nobody Wed Mar 8 20:45:17 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PX4894tFfz3wrL4; Wed, 8 Mar 2023 20:45:29 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PX48944G4z47Zv; Wed, 8 Mar 2023 20:45:29 +0000 (UTC) (envelope-from kevans@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1678308329; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=U5BIyqT5L8GPah2ihFsE3OS3NVrS8F5pQgzoXBqbO5s=; b=lwCsDu+/+wTT5zDfgNLVhX2BoYTLl7il7Dj3sAl2ag/RrVa2UKVmljL1P9BHp+ioRez9f3 49rZBJ6xRKtYjikVBTNoywu2EIJcY5OBhYZlsEP9zZHRP32NB3Q72pV+klSs1eyw7IaUB5 1Gq9qBH4xrJHPht4tECTQJ5EV+Om3SNry/Iyyj5tGBGcK+Qjf124Rf7/WVCuNTuI/O64+P 7ouYIREvidT8GBgEyCD4a9VVyMRDE2PWKEtQ6c1t7/uPl0kcQMWkvLPYvQTpwwARBeE7I9 3xnPZZe97A4WE2eisLzPauJAD7OEpU69ek98iXJBCXoefZyRQ11xdkf4ZioPBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1678308329; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=U5BIyqT5L8GPah2ihFsE3OS3NVrS8F5pQgzoXBqbO5s=; b=j9pPMWZyj/4p57ZMhEmzQs0F0KPGN7lOZ+AMCnyMEKQwQ9wfmLl2hgKmCCXaadSgK8JyB3 7WnLNr0DTq2ZkoM67UMqblSlUODnXJscFvfqYRAHnnU/fenAhS7hSXeNNhooX3nOD/Xo/v 5Gs4b6gK2eZoQ81Cn6aukpjoQ6ujwYYIjd/xaYGpYxiro4vZ6V426lV2lUS4Ydz/M9dUqz gZdDbZ+LAc1G943ioGc1MsODQumg4sgGm8KaTojx4V5xCHR+5sd/70W7nsO3zI2GjfKK/o p0oeGqDaRGODIaw70KUf6tkboXJaLhXVqCNhOoQLfjQx/iGnIFHCD8p1Hoiszw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1678308329; a=rsa-sha256; cv=none; b=IAVMG/n8UWdNXyCLRAK6JdgbAL5f9/3gpw2g7QbhMb0mJC1tBulu4UlWyLYqBcZRsp/osT alGaYzzDE5JfG48nJynpiyuXsPEmsrfKN9bjvkJExVGrjrm3pM880ytGUjmntO3FUoPTnn orUQZnH8DfhshdN/ebC0ULI3fsHt/7vK2QQadBiAY7qgqwImb0sZLf7eS+s7PSpc5PdTw/ vdErQh7Hg9CHkxYaXDyXXyaNq8PGBlV5UcUlYrg0VLyeSBT/fcAYLCOZiuTOwOeku2AoHn ck3XpF5sCPFE7j847PYj4NxCGZeM2AdGcEmYopHbryvGnmo942tk94KXedisqQ== Received: from mail-qt1-f169.google.com (mail-qt1-f169.google.com [209.85.160.169]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id 4PX48932NMz19Rl; Wed, 8 Mar 2023 20:45:29 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-qt1-f169.google.com with SMTP id l18so19605818qtp.1; Wed, 08 Mar 2023 12:45:29 -0800 (PST) X-Gm-Message-State: AO0yUKWyDSolch+uduq+Yr+8mRlyWSPKqnp1hHzTa2jP+pua4+pbdzT1 lU+SopujNdryRccbj7vRiuZO2Xr9ushWMA6EtZ4= X-Google-Smtp-Source: AK7set9resPESEiobdui8/yVc5GD/LSxD/q+yJiG/Jb49+sLeQWxqBz64TOiuiKwtXux0N7drSZbKGbW8vG3VkDOtQE= X-Received: by 2002:aed:2785:0:b0:3bd:1a0b:8ac4 with SMTP id a5-20020aed2785000000b003bd1a0b8ac4mr5565052qtd.1.1678308328816; Wed, 08 Mar 2023 12:45:28 -0800 (PST) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 References: <202303082001.328K1iMn005869@gitrepo.freebsd.org> In-Reply-To: From: Kyle Evans Date: Wed, 8 Mar 2023 14:45:17 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 175a584e501e - main - usb: dwc3: add To: Joerg Wunsch Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-ThisMailContainsUnwantedMimeParts: N On Wed, Mar 8, 2023 at 2:24=E2=80=AFPM Joerg Wunsch w= rote: > > As Kyle Evans wrote: > > > > Commit 5e54bb1ea9e90 added USB_BUS_LOCK/USB_BUS_UNLOCK. They, in > > > consequence, require mutexes so is needed. > > > > Whoops, thanks! > > You're welcome. > > I'm just trying to compile a current kernel on a RockPi 4 (arm64), and > it broke. > > While the reason for this one was rather obvious, the second breakage > though is more of a mystery to me: > > sys/dev/dpaa2/dpaa2_mc.c fails to compile since LA_UNLOCKED is > undefined. This is aliased to MA_NOTOWNED in . > > Sure, I can get it to compile by adding to that file, but > I don't see why it could ever compile at all. OTOH, wouldn't it make > sense that itself included ? > It looks like it's getting it via pollution from ACPI headers or from sys/mutex.h -> sys/lock_profiling.h -> sys/lock.h with LOCK_PROFILING enabling. It would make sense, but we've only semi-recently started considering making headers self-contained. Thanks, Kyle Evans