From nobody Sat Feb 4 15:07:14 2023 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4P8G901ygjz3nVkw for ; Sat, 4 Feb 2023 15:07:32 +0000 (UTC) (envelope-from adamw@adamw.org) Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4P8G900CWxz3vvl for ; Sat, 4 Feb 2023 15:07:32 +0000 (UTC) (envelope-from adamw@adamw.org) Authentication-Results: mx1.freebsd.org; none Received: by mail-ej1-x636.google.com with SMTP id ml19so23050726ejb.0 for ; Sat, 04 Feb 2023 07:07:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adamw-org.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=W5i9RmebFNhkfN73qtuXQx6LxYUccVvRu9sleYPeD3o=; b=OOlBGkd+sNurfkQGUPbz+CaTMIQQ9Q6A2ycb5XHkPFtnGGVo41tNVaoGH/moc5KrPk dI/aqrWJ8WD5FTaIsk+o0OY49wtkavt84ZtIR74dLAR1sFlYlYk6OuDuNh8xWfpD+nuQ QAkkiHPIvD8iQbPiKjgle6Kg6eKtWIwxcr9z119Lii1z3xKIh2/wrIPIijYEaHVR5N8J 02FmFOj6txIUDP8PguieBzgt1fTZK5yLsrHwJtI3vmP2x/2FVmGkPZFHqUpoaWOsksPt WQgNej1Frenu37gkk7aWATKV7A+St5ecmiqJcihrImOvFUFcZIL56xsekVGtODWSWzdi kAiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=W5i9RmebFNhkfN73qtuXQx6LxYUccVvRu9sleYPeD3o=; b=KkaKq7pRYtAg3B+NAqFpFxsrr0AHVntj+LAo/LPTrkBoAKaBnW5NhcSdy8dBOeD00G ifypm9W3Ma9APcnxPbb5YVfXa4iQCjgeQkrbXIUgqPa1uTl7izSuCI506mvamb8CLfCR ah8y8QRaP+QqxRudHSQS9UglO3WeBNpQANfsSgbvobB68rC3CMiGL0sKG4jcqyivij8c SEsz+/pclluOlIS61+MXPpOj6hI4eisj0y9KANoRZIVDkvQXjB3nHSh08rODNA4pm468 xlLQVQfSAzkceKCMy5bN0mptwEHpb9Eb2bkKlBqm4RRvQK+5L17dt4C5gU7C5rVGvsyH SKPw== X-Gm-Message-State: AO0yUKWi2RXSY4SylnAEaqsIvugKv5dljpyRtvERUPXyjcTpyPatW6Qq pgmyEYIeyKzarOrSJo73bbFopsrv0Tcq3nlyivCc5t5g5vmMabo8o1A= X-Google-Smtp-Source: AK7set8UKg+IBsOHuf1gWR5CYCbPDeogMSw7aAdJN1jPGHwJF/2A/qhNK7sUwr/Gx22iRcH1bbIYpGPOYqnPF2Hc3Js= X-Received: by 2002:a17:906:1446:b0:889:14ec:21a7 with SMTP id q6-20020a170906144600b0088914ec21a7mr3962576ejc.202.1675523250625; Sat, 04 Feb 2023 07:07:30 -0800 (PST) List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 References: <202302031951.313Jp8eE067836@gitrepo.freebsd.org> In-Reply-To: <202302031951.313Jp8eE067836@gitrepo.freebsd.org> From: Adam Weinberger Date: Sat, 4 Feb 2023 10:07:14 -0500 Message-ID: Subject: Re: git: e41e27b19194 - main - www/caddy: Pin Go version to 1.19 To: Dmitri Goutnik Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: multipart/alternative; boundary="0000000000002aae7805f3e1281b" X-Rspamd-Queue-Id: 4P8G900CWxz3vvl X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N --0000000000002aae7805f3e1281b Content-Type: text/plain; charset="UTF-8" On Fri, Feb 3, 2023 at 2:51 PM Dmitri Goutnik wrote: > The branch main has been updated by dmgk: > > URL: > https://cgit.FreeBSD.org/ports/commit/?id=e41e27b19194be93c1bad06a10dafc9211264960 > > commit e41e27b19194be93c1bad06a10dafc9211264960 > Author: Dmitri Goutnik > AuthorDate: 2023-02-03 15:55:51 +0000 > Commit: Dmitri Goutnik > CommitDate: 2023-02-03 18:09:08 +0000 > > www/caddy: Pin Go version to 1.19 > > vendor/github.com/lucas-clemente/quic-go/internal/qtls/go120.go:5:13: > cannot use "The version of quic-go you're using can't be built on Go 1.20 > yet. > > quic-go doesn't support go1.20 yet, keep building this port with go1.19 > for now. > > PR: 269289 > Reported by: exp-run > --- > www/caddy/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/www/caddy/Makefile b/www/caddy/Makefile > index 433acbb98efa..549ce5311644 100644 > --- a/www/caddy/Makefile > +++ b/www/caddy/Makefile > @@ -12,7 +12,7 @@ WWW= https://caddyserver.com > LICENSE= APACHE20 > LICENSE_FILE= ${WRKSRC}/LICENSE > > -USES= cpe go:modules > +USES= cpe go:1.19,modules > CPE_VENDOR= caddyserver > > USE_RC_SUBR= caddy > Thanks for doing this! In the past I've manually recreated GH_TUPLE (> 110 modules) every time Go gets a minor bump, but pinning Go until the next caddy release looks like a much better option. For anyone playing at home, some subtle path-handling semantics changed in go1.20, so it's not as simple as just bumping the quic-go dep this time. The PR is https://github.com/caddyserver/caddy/pull/5353. # Adam -- Adam Weinberger adamw@adamw.org https://www.adamw.org --0000000000002aae7805f3e1281b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


<= div dir=3D"ltr" class=3D"gmail_attr">On Fri, Feb 3, 2023 at 2:51 PM Dmitri = Goutnik <dmgk@freebsd.org> wr= ote:
The branch = main has been updated by dmgk:

URL: https://cgi= t.FreeBSD.org/ports/commit/?id=3De41e27b19194be93c1bad06a10dafc9211264960

commit e41e27b19194be93c1bad06a10dafc9211264960
Author:=C2=A0 =C2=A0 =C2=A0Dmitri Goutnik <dmgk@FreeBSD.org>
AuthorDate: 2023-02-03 15:55:51 +0000
Commit:=C2=A0 =C2=A0 =C2=A0Dmitri Goutnik <dmgk@FreeBSD.org>
CommitDate: 2023-02-03 18:09:08 +0000

=C2=A0 =C2=A0 www/caddy: Pin Go version to 1.19

=C2=A0 =C2=A0 vendor/github.com/= lucas-clemente/quic-go/internal/qtls/go120.go:5:13: cannot use "Th= e version of quic-go you're using can't be built on Go 1.20 yet.
=C2=A0 =C2=A0 quic-go doesn't support go1.20 yet, keep building this po= rt with go1.19
=C2=A0 =C2=A0 for now.

=C2=A0 =C2=A0 PR:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0269289
=C2=A0 =C2=A0 Reported by:=C2=A0 =C2=A0 exp-run
---
=C2=A0www/caddy/Makefile | 2 +-
=C2=A01 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/www/caddy/Makefile b/www/caddy/Makefile
index 433acbb98efa..549ce5311644 100644
--- a/www/caddy/Makefile
+++ b/www/caddy/Makefile
@@ -12,7 +12,7 @@ WWW=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 https://caddyserve= r.com
=C2=A0LICENSE=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0APACHE20
=C2=A0LICENSE_FILE=3D=C2=A0 ${WRKSRC}/LICENSE

-USES=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 cpe go:modules
+USES=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 cpe go:1.19,modules
=C2=A0CPE_VENDOR=3D=C2=A0 =C2=A0 caddyserver

=C2=A0USE_RC_SUBR=3D=C2=A0 =C2=A0caddy

Thanks for doing this! In the past I've= manually recreated GH_TUPLE (> 110 modules) every time Go gets a minor = bump, but pinning Go until the next caddy release looks like a much better = option.

For anyone playing at home, some subtle path-handling semantics ch= anged in go1.20, so it's not as simple as just bumping the quic-go dep = this time. The PR is https://github.com/caddyserver/caddy/pull/5353.

# Adam


--
--0000000000002aae7805f3e1281b--