From owner-freebsd-doc@FreeBSD.ORG  Wed Oct 26 20:38:28 2005
Return-Path: <owner-freebsd-doc@FreeBSD.ORG>
X-Original-To: freebsd-doc@FreeBSD.org
Delivered-To: freebsd-doc@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 17F7C16A41F;
	Wed, 26 Oct 2005 20:38:28 +0000 (GMT)
	(envelope-from bsd@unixforge.net)
Received: from mail.sectornotfound.com (mail.sectornotfound.com
	[209.139.233.100])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 7EDD743D62;
	Wed, 26 Oct 2005 20:38:25 +0000 (GMT)
	(envelope-from bsd@unixforge.net)
Received: from hannibal.int.sectornotfound.com
	(hannibal.int.sectornotfound.com [192.168.98.3])
	by murdock.sectornotfound.com (8.13.1/8.13.1) with ESMTP id
	j9QKcO8j042585; Wed, 26 Oct 2005 13:38:24 -0700 (PDT)
	(envelope-from bsd@unixforge.net)
Received: from [192.168.3.212] (gw.activestate.com [209.17.183.249])
	(authenticated bits=0)
	by hannibal.int.sectornotfound.com (8.13.1/8.12.10) with ESMTP id
	j9QKcMiU032220; Wed, 26 Oct 2005 13:38:23 -0700 (PDT)
	(envelope-from bsd@unixforge.net)
Message-ID: <435FE939.6070203@unixforge.net>
Date: Wed, 26 Oct 2005 13:38:17 -0700
From: "Eli K. Breen" <bsd@unixforge.net>
User-Agent: Mozilla Thunderbird 1.0 (X11/20050101)
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Giorgos Keramidas <keramida@FreeBSD.org>
References: <200510262020.j9QKKv4Q073769@freefall.freebsd.org>
In-Reply-To: <200510262020.j9QKKv4Q073769@freefall.freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: freebsd-doc@FreeBSD.org
Subject: Re: docs/87351: Jail building instructions don't work as described
 with default CSH shell
X-BeenThere: freebsd-doc@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Documentation project <freebsd-doc.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-doc>,
	<mailto:freebsd-doc-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-doc>
List-Post: <mailto:freebsd-doc@freebsd.org>
List-Help: <mailto:freebsd-doc-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-doc>,
	<mailto:freebsd-doc-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 26 Oct 2005 20:38:28 -0000

Call me madcap, but wouldn't it make more sense to have the base case 
example match the default shell, with exceptions for other shells as the 
side-comments?

Given how little of this script/instructions need to change to suit csh, 
something like...

[...]
#For csh
	set D=/here/is/the/jail
#For bourne shells (sh,bash,...)
	D=/here/is/the/jail
cd /usr/src
mkdir -p $D
[...]

or

[...]
#For csh
	set D=/here/is/the/jail
#For bourne shells (sh,bash,...)
#	D=/here/is/the/jail
cd /usr/src
mkdir -p $D
[...]

The former solution is both legible and functional. If you dump it on 
the command-line verbatim, it will produce an error for whichever 
environment export didn't work, but the process overall will work, and 
the latter is a little cleaner, and won't produce any errors with the 
base shell. A happy user experience overall.

-Eli


Giorgos Keramidas wrote:
> Synopsis: Jail building instructions don't work as described with default CSH shell
> 
> State-Changed-From-To: open->patched
> State-Changed-By: keramida
> State-Changed-When: Wed Oct 26 20:18:41 GMT 2005
> State-Changed-Why: 
> 
> I've just committed a note that points to sh(1) in CURRENT.
> The change will be MFC'ed in a few days.  If I get approval
> early enough it will even be in 6.0-RELEASE.
> 
> Thanks for the problem report :)
> 
> http://www.freebsd.org/cgi/query-pr.cgi?pr=87351