From owner-svn-src-all@FreeBSD.ORG  Thu Jun 16 11:43:17 2011
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id DCAD41065678;
	Thu, 16 Jun 2011 11:43:17 +0000 (UTC)
	(envelope-from avatar@mmlab.cse.yzu.edu.tw)
Received: from www.mmlab.cse.yzu.edu.tw (www.mmlab.cse.yzu.edu.tw
	[140.138.150.166])
	by mx1.freebsd.org (Postfix) with ESMTP id 48F048FC19;
	Thu, 16 Jun 2011 11:43:17 +0000 (UTC)
Received: by www.mmlab.cse.yzu.edu.tw (qmail, from userid 1000)
	id 5E6B52EC686B; Thu, 16 Jun 2011 19:24:27 +0800 (CST)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mmlab.cse.yzu.edu.tw;
	s=test; t=1308223467;
	bh=tun5da0OQEXwDzIyw/c/SX+KoMfFhCqWc92OiBosWFg=;
	h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:
	MIME-Version:Content-Type;
	b=Ccy3uSNme4OaUfRS0zwJjSmoPk0F63IKkHNiUrcY5kgbZIv79f8aEo9B4cMfFA+Pv
	XF2LHvbYfWhLxmwiYYB0FiQFVU2IaXVVwV/a8KsKcMdXxUZ23mt9ZgNke376BWjGIe
	efMSOvUuGdSL5M9cKBT9EL5u8PS83BNzpQgbWMdc=
Received: from localhost (localhost [127.0.0.1])
	by www.mmlab.cse.yzu.edu.tw (qmail) with ESMTP id 5DEEF2EC6866;
	Thu, 16 Jun 2011 19:24:27 +0800 (CST)
Date: Thu, 16 Jun 2011 19:24:27 +0800 (CST)
From: Tai-hwa Liang <avatar@mmlab.cse.yzu.edu.tw>
To: Bruce Evans <brde@optusnet.com.au>
In-Reply-To: <20110616175314.R935@besplex.bde.org>
Message-ID: <1106161923211.44181@www.mmlab.cse.yzu.edu.tw>
References: <201106160526.p5G5Q3RX013915@svn.freebsd.org>
	<20110616065310.GA2542@mole.fafoe.narf.at>
	<20110616175314.R935@besplex.bde.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: Tai-hwa Liang <avatar@freebsd.org>, svn-src-head@freebsd.org,
	svn-src-all@freebsd.org, Stefan Farfeleder <stefanf@freebsd.org>,
	src-committers@freebsd.org
Subject: Re: svn commit: r223138 - head/sys/ufs/ffs
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 16 Jun 2011 11:43:18 -0000

On Thu, 16 Jun 2011, Bruce Evans wrote:
> On Thu, 16 Jun 2011, Stefan Farfeleder wrote:
>
>>> Log:
>>>   Fixing compilation bustage by introducing another forward declaration.
>>> 
>>> Modified:
>>>   head/sys/ufs/ffs/ffs_extern.h
>>> 
>>> Modified: head/sys/ufs/ffs/ffs_extern.h
>>> ==============================================================================
>>> --- head/sys/ufs/ffs/ffs_extern.h	Thu Jun 16 02:27:05 2011 
>>> (r223137)
>>> +++ head/sys/ufs/ffs/ffs_extern.h	Thu Jun 16 05:26:03 2011 
>>> (r223138)
>>> @@ -33,6 +33,7 @@
>>>  #ifndef _UFS_FFS_EXTERN_H
>>>  #define	_UFS_FFS_EXTERN_H
>>> 
>>> +enum vtype;
>>>  struct buf;
>>>  struct cg;
>>>  struct fid;
>
> This might unsort the declarations (it isn't clear if the declarations
> should be sorted on tag name or keyword name).
>
>> This is not valid C code. For some reason GCC allows it (with our
>> compilation flags).
>
> This is a bug in gcc-4.2.1.  gcc-3.3.3 generates a warning for it even
> with no compilation flags, while gcc-4.2.1 doesn't generate a warning
> even with -Wall -std-c99.  It takes -pedantic to generate the warning
> with gcc-4.2.1.  TenDRA of course generates an error.
>
> It might be a style bug (like typedefing a struct) to use enums for
> anything.  They are impossible to declare opaquely.

   Does that mean we have to #include <sys/vnode.h> in userland 
makefs/ffs/ffs_bswap.c?