From owner-svn-src-head@freebsd.org  Sat Jul  1 02:19:52 2017
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id E2489DA300D;
 Sat,  1 Jul 2017 02:19:52 +0000 (UTC) (envelope-from imp@FreeBSD.org)
Received: from repo.freebsd.org (repo.freebsd.org
 [IPv6:2610:1c1:1:6068::e6a:0])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 4B435326F;
 Sat,  1 Jul 2017 02:19:52 +0000 (UTC) (envelope-from imp@FreeBSD.org)
Received: from repo.freebsd.org ([127.0.1.37])
 by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id v612Jnkj047874;
 Sat, 1 Jul 2017 02:19:49 GMT (envelope-from imp@FreeBSD.org)
Received: (from imp@localhost)
 by repo.freebsd.org (8.15.2/8.15.2/Submit) id v612JnCm047873;
 Sat, 1 Jul 2017 02:19:49 GMT (envelope-from imp@FreeBSD.org)
Message-Id: <201707010219.v612JnCm047873@repo.freebsd.org>
X-Authentication-Warning: repo.freebsd.org: imp set sender to imp@FreeBSD.org
 using -f
From: Warner Losh <imp@FreeBSD.org>
Date: Sat, 1 Jul 2017 02:19:49 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: svn commit: r320522 - head/sbin/nvmecontrol
X-SVN-Group: head
X-SVN-Commit-Author: imp
X-SVN-Commit-Paths: head/sbin/nvmecontrol
X-SVN-Commit-Revision: 320522
X-SVN-Commit-Repository: base
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 01 Jul 2017 02:19:53 -0000

Author: imp
Date: Sat Jul  1 02:19:48 2017
New Revision: 320522
URL: https://svnweb.freebsd.org/changeset/base/320522

Log:
  Fix sign of resid and add a mostly useless cast to cope with signed vs
  unsigned check warnings from traditional unix code construsts bogusly
  flagged as potentially unsafe.

Modified:
  head/sbin/nvmecontrol/wdc.c

Modified: head/sbin/nvmecontrol/wdc.c
==============================================================================
--- head/sbin/nvmecontrol/wdc.c	Fri Jun 30 23:53:40 2017	(r320521)
+++ head/sbin/nvmecontrol/wdc.c	Sat Jul  1 02:19:48 2017	(r320522)
@@ -105,7 +105,7 @@ wdc_do_dump(int fd, char *tmpl, const char *suffix, ui
 	int fd2;
 	uint8_t *buf;
 	uint32_t len, offset;
-	ssize_t resid;
+	size_t resid;
 
 	wdc_append_serial_name(fd, tmpl, MAXPATHLEN, suffix);
 
@@ -142,7 +142,7 @@ wdc_do_dump(int fd, char *tmpl, const char *suffix, ui
 				resid = len;
 			first = 0;
 		}
-		if (write(fd2, buf, resid) != resid)
+		if (write(fd2, buf, resid) != (ssize_t)resid)
 			err(1, "write");
 		offset += resid;
 		len -= resid;