From owner-svn-src-head@freebsd.org Tue Jun 5 19:22:34 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9DD9EFF348A for ; Tue, 5 Jun 2018 19:22:34 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic304-23.consmr.mail.gq1.yahoo.com (sonic304-23.consmr.mail.gq1.yahoo.com [98.137.68.204]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 1EA216DA58 for ; Tue, 5 Jun 2018 19:22:33 +0000 (UTC) (envelope-from marklmi@yahoo.com) X-YMail-OSG: NIPrG.0VM1kIdGAKOFinYYiUZnPIlS42DrskxScFRq3hNMp8T0ELy5hzYDmAyO3 h4JtjfnhsAvqJvNqQwRFL2O65RkDaliHfjbkNU9Km6JHnAuQslkhBujf6qvZ4H7TGDQhlt_vU1Xl I1bhz53AY0.zfO77HoL5egPKarDEgvl0Eb9D1S9ZuPaXLuWZL2tyrQRYmUNOXTTnAvyCYWKwgMJD Nq_kE.5.9mOAwgBtBbnOoNWFdQe16c0ljNoxOHi6BrV_41mrB0G908oCX1SYESfN.Vfd_1KbGq_K mFGnS5GFVEw05YUWANdg0Kd_vCpSzKtOG_6sgcUXk1QCCoii.b8qzq7uuBmeGazmp6_aFsza3DhE fMn6uqbXUv3ZwVBIIKCcBCt9iYVcJ0UmvydwN5wZP8jEfmt0BtjhCZoFLZyPFyrsrW6i3yXwwD9Y 4JzheZrhiJ5KkLQ4Yje8Pco_4iR3RlQwKgYhpXLU1UWwTX.TNwxD0UcYizKCXpwr9vky7B.anbUW 5Z0ncN7OQR1A41nDy_Qg4bxYRs.Y23YpzEnIWEEJkJ2m8r.dWeTVGJBMNrmpzP5P_cYqx_SsUnSB imB4fZyFF0wqR_nj25JBnfQ_dsT5ld0htduZ_mg_V_CngsZqBHxb8SqqH0Q9CnVyygQ26Ye2oKUX sCbTHA2deTIvuoDYT_PJQ1CQT.XDdB93Fwx6kghpq2p4UJjcNPq4SsKSRTwsdACLJFcmcj8j8nuw O9ggyJKc7Bht04wNpvZXTtmKJurQ49xtc5gR1M0AYK7530oJttEn9DFcdPplh2hjSmBdH5jSNsWA vK15ofTjO4gvBI3ISgt2uGNZP4lLMPePLb7X17mmTDl8Dp1ZN1C0M39NBfCzuP9tFyjvib4D5lxJ N1Tyl.iBuDM5u9Td7nsnATq.vCIoub7rSdJuMIdr0lVieBKd26DLIYqCvi6GTHoZ0UqkZ9VWm8XG 6QJY- Received: from sonic.gate.mail.ne1.yahoo.com by sonic304.consmr.mail.gq1.yahoo.com with HTTP; Tue, 5 Jun 2018 19:22:27 +0000 Received: from ip70-189-131-151.lv.lv.cox.net (EHLO [192.168.0.109]) ([70.189.131.151]) by smtp410.mail.gq1.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 2d247965ef310013e7a4fd69125e4972; Tue, 05 Jun 2018 19:22:22 +0000 (UTC) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 11.4 \(3445.8.2\)) Subject: Re: svn commit: r334647 - in head: . . . [this broke ci.freebsd.org's FreeBSD-head-amd64-gcc build but via an include/c++/v1/ problem] From: Mark Millard In-Reply-To: <39385E73-A75B-4E61-91D3-4CA86252AEDA@FreeBSD.org> Date: Tue, 5 Jun 2018 12:22:21 -0700 Cc: svn-src-head@freebsd.org, freebsd-toolchain@freebsd.org, mmacy@FreeBSD.org Content-Transfer-Encoding: quoted-printable Message-Id: <317A4775-F397-4C54-9DE4-2FCD5E53D5B2@yahoo.com> References: <5D1C2920-2206-4602-BD2D-D1298E5D62EE@yahoo.com> <39385E73-A75B-4E61-91D3-4CA86252AEDA@FreeBSD.org> To: Dimitry Andric X-Mailer: Apple Mail (2.3445.8.2) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Jun 2018 19:22:34 -0000 On 2018-Jun-5, at 10:49 AM, Dimitry Andric wrote: > On 5 Jun 2018, at 15:03, Mark Millard via freebsd-toolchain = wrote: >>=20 >> https://ci.freebsd.org/job/FreeBSD-head-amd64-gcc/5974/consoleText = shows: >>=20 >> --- all_subdir_usr.sbin/pmc --- >> In file included from = /workspace/obj/workspace/src/amd64.amd64/tmp/usr/include/c++/v1/ios:216:0,= >> from = /workspace/obj/workspace/src/amd64.amd64/tmp/usr/include/c++/v1/iostream:3= 8, >> from /workspace/src/usr.sbin/pmc/cmd_pmc_filter.cc:71: >> = /workspace/obj/workspace/src/amd64.amd64/tmp/usr/include/c++/v1/__locale: = At global scope: >> = /workspace/obj/workspace/src/amd64.amd64/tmp/usr/include/c++/v1/__locale:1= 237:40: error: redundant redeclaration of 'void = std::__1::__throw_runtime_error(const char*)' in same scope = [-Werror=3Dredundant-decls] >> _LIBCPP_NORETURN _LIBCPP_FUNC_VIS void __throw_runtime_error(const = char*); >> ^~~~~~~~~~~~~~~~~~~~~ >> In file included from = /workspace/obj/workspace/src/amd64.amd64/tmp/usr/include/c++/v1/memory:663= :0, >> from = /workspace/obj/workspace/src/amd64.amd64/tmp/usr/include/c++/v1/algorithm:= 643, >> from = /workspace/obj/workspace/src/amd64.amd64/tmp/usr/include/c++/v1/__string:5= 6, >> from = /workspace/obj/workspace/src/amd64.amd64/tmp/usr/include/c++/v1/string_vie= w:176, >> from = /workspace/obj/workspace/src/amd64.amd64/tmp/usr/include/c++/v1/string:477= , >> from = /workspace/obj/workspace/src/amd64.amd64/tmp/usr/include/c++/v1/__locale:1= 5, >> from = /workspace/obj/workspace/src/amd64.amd64/tmp/usr/include/c++/v1/ios:216, >> from = /workspace/obj/workspace/src/amd64.amd64/tmp/usr/include/c++/v1/iostream:3= 8, >> from /workspace/src/usr.sbin/pmc/cmd_pmc_filter.cc:71: >> = /workspace/obj/workspace/src/amd64.amd64/tmp/usr/include/c++/v1/stdexcept:= 186:40: note: previous declaration of 'void = std::__1::__throw_runtime_error(const char*)' >> _LIBCPP_NORETURN _LIBCPP_FUNC_VIS void __throw_runtime_error(const = char*); >> ^~~~~~~~~~~~~~~~~~~~~ >>=20 >>=20 >> It looks like the new #include of iostream brings in code that gcc = rejected above: >>=20 >> --- head/usr.sbin/pmc/cmd_pmc_filter.c Mon Jun 4 23:17:18 2018 = (r334645, copy source) >> +++ head/usr.sbin/pmc/cmd_pmc_filter.cc Tue Jun 5 04:26:40 2018 = (r334647) >> @@ -68,11 +68,22 @@ __FBSDID("$FreeBSD$"); >> #include >> #include "cmd_pmc.h" >>=20 >> +#include >> . . . >=20 > I don't think anybody has yet tested building libc++ headers with the > combination of recent gcc, -Wsystem-headers, and -Werror. :) >=20 > For now, try disabling -Wredundant-decls. >=20 ci.freebsd.org 's FreeBSD-head-amd64-gcc #5973 ( -r334645 ) is the last build that worked. #5973 ( -r334647 ) is the first that failed. Maybe pmc forces -Werror and/or -Wredundant-decls since its new use of include is what seems to matter for the failure. But, prior to that additional include, FreeBSD-head-amd64-gcc was building fine on ci.freebsd.org . (I have no control over ci.freebsd.org builds, which is the context I reported the problem for.) =3D=3D=3D Mark Millard marklmi at yahoo.com ( dsl-only.net went away in early 2018-Mar)