From owner-cvs-all Thu Jun 8 22:12:42 2000 Delivered-To: cvs-all@freebsd.org Received: from info.iet.unipi.it (info.iet.unipi.it [131.114.9.184]) by hub.freebsd.org (Postfix) with ESMTP id A4BB337B547; Thu, 8 Jun 2000 22:12:33 -0700 (PDT) (envelope-from luigi@info.iet.unipi.it) Received: (from luigi@localhost) by info.iet.unipi.it (8.9.3/8.9.3) id HAA07550; Fri, 9 Jun 2000 07:11:59 +0200 (CEST) (envelope-from luigi) From: Luigi Rizzo Message-Id: <200006090511.HAA07550@info.iet.unipi.it> Subject: Re: cvs commit: src/sbin/ipfw ipfw.8 In-Reply-To: <3940510C.2781E494@elischer.org> from Julian Elischer at "Jun 8, 2000 07:06:04 pm" To: Julian Elischer Date: Fri, 9 Jun 2000 07:11:59 +0200 (CEST) Cc: Kris Kennaway , Luigi Rizzo , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG X-Mailer: ELM [version 2.4ME+ PL61 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > > > If you look at the changes, the code to support WFQ in dummynet > > > is in the order of 500 lines, many of them being comment and > > > [gs]etsockopt() support. > > > > I guess what concerns me is stuffing more and more code into ipfw, which > > is already a pretty complicated and messy beast. technically it's <10 lines in ip_fw.c and the rest in ip_dummynet.c > I would like to see the functioality of ipfw broken out to a set of > netgraph modules. > Netgraph in -current now has the capability of supporting this. I am open to discussion on this issue. I would like again to raise the two points of backward compatibility and ease of use/implementation. By putting this stuff in dummynet i did a relatively modest programming effort (read: i could scatter it over time without having to become familiar with netgraph); and users currently using ipfw and dummynet pipes to throttle traffic can now benefit of WFQ by changing only two lines in their (sometimes complex) ipfw configuration: from: ipfw pipe NN to: ipfw queue NN ipfw queue NN config pipe NN mask What is messy in ipfw is the user interface, but i dont think you will gain anything by moving part of its functionality to another command. cheers luigi -----------------------------------+------------------------------------- Luigi RIZZO, luigi@iet.unipi.it . Dip. di Ing. dell'Informazione http://www.iet.unipi.it/~luigi/ . Universita` di Pisa TEL/FAX: +39-050-568.533/522 . via Diotisalvi 2, 56126 PISA (Italy) Mobile +39-347-0373137 -----------------------------------+------------------------------------- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message