From owner-freebsd-ports@FreeBSD.ORG Mon Nov 27 15:33:19 2006 Return-Path: X-Original-To: ports@freebsd.org Delivered-To: freebsd-ports@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 48CC016A4FC; Mon, 27 Nov 2006 15:33:19 +0000 (UTC) (envelope-from mi+kde@aldan.algebra.com) Received: from aldan.algebra.com (aldan.algebra.com [216.254.65.224]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0A7AF43DFA; Mon, 27 Nov 2006 15:31:18 +0000 (GMT) (envelope-from mi+kde@aldan.algebra.com) Received: from aldan.algebra.com (aldan [127.0.0.1]) by aldan.algebra.com (8.13.8/8.13.7) with ESMTP id kARFWJB7087692 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 27 Nov 2006 10:32:19 -0500 (EST) (envelope-from mi+kde@aldan.algebra.com) Received: from localhost (localhost [[UNIX: localhost]]) by aldan.algebra.com (8.13.8/8.13.7/Submit) id kARFWI34087691; Mon, 27 Nov 2006 10:32:18 -0500 (EST) (envelope-from mi+kde@aldan.algebra.com) From: Mikhail Teterin To: Norikatsu Shigemura Date: Mon, 27 Nov 2006 10:32:17 -0500 User-Agent: KMail/1.9.5 References: <20061127222709.aa35ab22.nork@FreeBSD.org> In-Reply-To: <20061127222709.aa35ab22.nork@FreeBSD.org> X-Face: %UW#n0|w>ydeGt/b@1-.UFP=K^~-:0f#O:D7whJ5G_<5143Bb3kOIs9XpX+"V+~$adGP:J|SLieM31VIhqXeLBli" Cc: ports@freebsd.org Subject: Re: ports/devel/icu: PTHREAD_LIBS clean X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Nov 2006 15:33:19 -0000 On Monday 27 November 2006 08:27, Norikatsu Shigemura wrote: = Hi mi! = = I found a problem that icu don't reflect PTHREAD_LIBS=ANY(like -lthr). = Please check following patch. Thanks, I'll try it... Do you need it to be thread-aware though? It is built by default without threads at all (because threads are/were busted on FreeBSD/ia64). ICU developers think, threads ought to be enabled, but there really is no software at the moment, which calls into ICU from multiple threads at the same time, AFAIK... -mi = Index: Makefile = =================================================================== = RCS file: /home/ncvs/ports/devel/icu/Makefile,v = retrieving revision 1.24 = diff -u -r1.24 Makefile = --- Makefile 9 Nov 2006 02:55:27 -0000 1.24 = +++ Makefile 26 Nov 2006 17:10:08 -0000 = @@ -67,6 +67,7 @@ = CONFIGURE_ARGS+= --enable-threads=yes = post-patch: = ${REINPLACE_CMD} -e 's,\(THREADSC.*FLAGS\).*,\1=${PTHREAD_CFLAGS},g' ${WRKSRC}/config/mh-bsd-gcc = + ${REINPLACE_CMD} -e 's,-lpthread,${PTHREAD_LIBS},g' ${WRKSRC}/configure = .else = CONFIGURE_ARGS+= --enable-threads=no = .endif