From owner-freebsd-doc Tue Sep 19 10: 1:15 2000 Delivered-To: freebsd-doc@freebsd.org Received: from scientia.demon.co.uk (scientia.demon.co.uk [212.228.14.13]) by hub.freebsd.org (Postfix) with ESMTP id 1EEB437B42C for ; Tue, 19 Sep 2000 10:01:08 -0700 (PDT) Received: from strontium.scientia.demon.co.uk ([192.168.91.36] ident=root) by scientia.demon.co.uk with esmtp (Exim 3.16 #1) id 13bPxu-000HPR-00; Tue, 19 Sep 2000 17:09:50 +0100 Received: (from ben@localhost) by strontium.scientia.demon.co.uk (8.9.3/8.9.3) id RAA47933; Tue, 19 Sep 2000 17:09:50 +0100 (BST) (envelope-from ben) Date: Tue, 19 Sep 2000 17:09:50 +0100 From: Ben Smithurst To: Eric Ogren Cc: freebsd-doc@freebsd.org Subject: Re: docs/21399: Handbook DHCP section doesn't mention bpf Message-ID: <20000919170950.A30774@strontium.scientia.demon.co.uk> References: <200009191500.IAA51171@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2i In-Reply-To: <200009191500.IAA51171@freefall.freebsd.org> Sender: owner-freebsd-doc@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org Eric Ogren wrote: > + There are two things you must do to have your system use > + DHCP upon startup: This looks reasonable, with a couple of minor complaints... You know what I'm like... :-) > + device is compiled into your kernel. To do this, add > + psuedo-device bpf to your kernel would be better than here, I think. > + The bpf device is already > + part of the GENERIC kernel that is Probably for GENERIC, but I'm not sure "GENERIC" is being used just as a filename. I don't think emphasis is right, I'd use (which I tend to use for anything I want in monospace when there isn't a better tag) if isn't right. > - > + > ifconfig_fxp0="DHCP" > - > + Please don't include gratuitous whitespace diffs along with a diff which changes content. It just makes life hard(er) for the translators, and in this case, difficult for whoever commits your patch since they'll have to fix it to remove the white space differences (and check if they are in fact only white space differences). If the indenting is wrong, please include a fix for that as a separate diff so it can be committed separately with a log message like "white space change only -- translators may ignore this commit". Other than that, it looks good. I shall have to warn you soon, that if you send many more good diffs like this, someone is likely to say "I'm sick of you, Eric. Here's your commit bit, now commit the damn patches yourself." :-) -- Ben Smithurst / ben@FreeBSD.org / PGP: 0x99392F7D To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-doc" in the body of the message