From owner-freebsd-current@FreeBSD.ORG Sat Jun 18 00:49:28 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 69051106564A for ; Sat, 18 Jun 2011 00:49:28 +0000 (UTC) (envelope-from minimarmot@gmail.com) Received: from mail-gw0-f54.google.com (mail-gw0-f54.google.com [74.125.83.54]) by mx1.freebsd.org (Postfix) with ESMTP id 22FC48FC08 for ; Sat, 18 Jun 2011 00:49:27 +0000 (UTC) Received: by gwb15 with SMTP id 15so40882gwb.13 for ; Fri, 17 Jun 2011 17:49:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=/vMAVvyeGUN5SyosJW7LVuJqv01PeTAI77lMrpTZQ4M=; b=RkAx2qYFt9WrkFYkntK6zki0OJKloCN6eKmvzQ5MrqCG+Z2Cumlc/5r3D/MMvMCZZn x2SylDpRoNArthHDEtv8E+6MQHaUJ3EpOw3ux1maTMhjj+HpxqScaHjrQIOYgtpLH8u5 7f58s0i4cfmKTdEeB3QjOErTUM5nTZgoeWbzk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=do+c8RzUNDqR71OPx3SdU7APVUfS3sl5CS9XtBiDREvExT0IfN1+m2CiJ9RPnlL2yJ DnRWqJnn7kydZPUJgqueasTFBHRORNSUwNq0mG/z+Mho1XSskhMjYVwCppmB7yrlUAtj d8uaY0vnfKRyuaa3FdotPiy4CUNzF9qZRZ/XY= MIME-Version: 1.0 Received: by 10.236.143.2 with SMTP id k2mr548262yhj.500.1308356284255; Fri, 17 Jun 2011 17:18:04 -0700 (PDT) Received: by 10.236.108.1 with HTTP; Fri, 17 Jun 2011 17:18:03 -0700 (PDT) In-Reply-To: <20090925123911.GP95398@hoeg.nl> References: <200909191756.n8JHuQCq031719@svn.freebsd.org> <86zl8jften.fsf@gmail.com> <20090925062134.GN95398@hoeg.nl> <20090925105729.GT47688@deviant.kiev.zoral.com.ua> <20090925123911.GP95398@hoeg.nl> Date: Fri, 17 Jun 2011 20:18:03 -0400 Message-ID: From: Ben Kaduk To: Ed Schouten Content-Type: text/plain; charset=ISO-8859-1 Cc: Kostik Belousov , Anonymous , freebsd-current@freebsd.org Subject: Re: [Patch] [regression] libvgl and r197330 (kbd) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Jun 2011 00:49:28 -0000 On Fri, Sep 25, 2009 at 8:39 AM, Ed Schouten wrote: > Hi all, > > * Kostik Belousov wrote: >> > Ah, it seems SDL also calls GIO_KEYMAP. Just rebuilding SDL should fix >> > this. I promised to add a message to UPDATING as well, so I'll also >> > mention SDL should be rebuilt as well. >> >> I consider this as a very strong argument to keep the existing ioctl >> as is, and provide new ioctl that takes new table. > > I've attached a patch that should restore binary compatibility. I first > thought this wasn't really needed, because most applications would use > K_RAW instead of K_XLATE anyway. > > Just breaking binary compatibility with kbdcontrol(1) wouldn't have been > too bad, but it turns out things like SDL use this as well. I've > attached a patch that should restore binary compatibility. Anyone > interested in testing this before I commit it to SVN? Replying to ancient history, it looks like this patch never got committed? The Debian kFreeBSD folks have run into a similar issue: http://lists.debian.org/debian-bsd/2011/06/msg00238.html proposing =============== Upstream could do it properly, without ABI breaking, i.e. by #define GIO_KEYMAP_OLD _IOR('k', 6, keymap_t) #define PIO_KEYMAP_OLD _IOW('k', 7, keymap_t) ... #define GIO_KEYMAP _IO('k', 16) #define PIO_KEYMAP _IO('k', 17) =============== Something to keep the ABI between 8 and 9 is probably still useful, even at this juncture. -Ben Kaduk