From nobody Fri Nov 28 01:00:50 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dHZjZ2Grwz6JY02 for ; Fri, 28 Nov 2025 01:00:50 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dHZjZ1W0Xz47TW for ; Fri, 28 Nov 2025 01:00:50 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1764291650; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=v+JW15XnIhjy3K1C8MrixecrEZCCrQjDl44Y5S7rqOo=; b=mKvujJriLqUXWxUqXf1XUox+ErsPEDp8M8BDB2MWQY02miRRsQOjMpOVay92SRjJFnZk+s EgwyTg4qRBBLgvGBwiz/UgoDVmh0u395wzNS38Prn+uB7uZ/n45qsqJWATqgMeSMiqQwF5 dH2lAqjMdv3IgG22XvsjxdN8yUns9h5Pcsgs1MYkFD95Zb+n8x2J4W6WnL6MDfqkGI+YIx xiJ7Kn9FQBVs9xc2Ql3Xw0olnRLnfu43OED4V6B9WCoCfCBdXVnwbWleztKGL1Uv8K+A+0 VgEff+3UfcjWqOiXoVDlaUAQhyJvOWUEPCfLoMq9erLuKmm5ipHqusrbmb3aHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1764291650; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=v+JW15XnIhjy3K1C8MrixecrEZCCrQjDl44Y5S7rqOo=; b=chW4rOKfk78OZuRs+s3FVL0wp71AW+578QYfVCGcsk7QCDzIBghzBK1PegiB4CW3J12q0/ KozxcLFr10FseDlKBlEwgj7CpzQxJpLKULXphpNlny9/2ClxULehNub3hk4FJbeaFtqH8a SpH+UKvfI2BWDxfVGjAoVqdSgeVDtk9bqwMZ1OOn5gAqQFL/KPGO2yj+EDAWQcpz9PPtBv YEWjGhJHacVRfUuMuj3L53IG0UssNyr87vMcQxahwzL2d8/JAwg4aMvuR76izHsGYdwqWG ioCbJO8kTenhavbAcH7+YGkidCtFHP7zNbWhv0EIzJMDrZFvcQJULUVISS240w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1764291650; a=rsa-sha256; cv=none; b=XJpd7U9VSbx2/y02sQ4c/dR1H+eLu5T0Y2FWrllXLD6ay6ebKTfxP8eZN0R2cEQbE/8IFe Bx0xqu+X9qH2YjFbGRq7N9dWqQTqtPn83lSh/gMb91N9ZBklAMhVFsk3WhrRQtL3CLebgi ZefS9TGC6i1sxb9Reu5kp1sPuKbKUkLyq6WgiDCTJEK12BddxYvUluyLMumLIB/HMYrDyp vi3z4+MYuC022aydC+gW7tGmwyQM+fbFWdJ61J64uUQD+cSG3r4dsIYigFB8dFxYVP8pgA cCc8EWPTWO1UV8Wxe30f5g8azuiCIBsT0dXutLMHlWnubrRXlrpAReHIFUD7Rw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4dHZjZ16gbzgvQ for ; Fri, 28 Nov 2025 01:00:50 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 278f4 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 28 Nov 2025 01:00:50 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Joseph Mingrone Subject: git: 6049f1bc2106 - main - git-arc: Fix failure to call arc() function List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jrm X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 6049f1bc210653b126974961b29d6eb71a6c6709 Auto-Submitted: auto-generated Date: Fri, 28 Nov 2025 01:00:50 +0000 Message-Id: <6928f442.278f4.18def5e9@gitrepo.freebsd.org> The branch main has been updated by jrm: URL: https://cgit.FreeBSD.org/src/commit/?id=6049f1bc210653b126974961b29d6eb71a6c6709 commit 6049f1bc210653b126974961b29d6eb71a6c6709 Author: Joseph Mingrone AuthorDate: 2025-11-27 22:46:43 +0000 Commit: Joseph Mingrone CommitDate: 2025-11-28 00:53:56 +0000 git-arc: Fix failure to call arc() function As of b3e53f9fff11, git-arc attempted to call the internal shell function, arc(), using env(1). However, because env(1) does not call shell functions, it actually attempted to run the arc utility. This led to errors: % git arc create -r xxx HEAD env: arc: No such file or directory git-arc: could not create Phabricator diff This change removes the unnecessary use of env(1), so the arc() function is correctly called. Reviewed by: markj Fixes: b3e53f9fff11 ("git-arc: Don't require devel/arcanist") Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D53972 --- tools/tools/git/git-arc.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/tools/git/git-arc.sh b/tools/tools/git/git-arc.sh index eef01b75663e..8507d96fda63 100755 --- a/tools/tools/git/git-arc.sh +++ b/tools/tools/git/git-arc.sh @@ -315,7 +315,7 @@ create_one_review() printf "\nSubscribers:\n" >> "$msg" printf "%s\n" "${subscribers}" >> "$msg" - yes | env EDITOR=true \ + yes | EDITOR=true \ arc diff --message-file "$msg" --never-apply-patches --create \ --allow-untracked $BROWSE --head "$commit" "${commit}~" [ $? -eq 0 ] || err "could not create Phabricator diff"