From owner-svn-src-all@freebsd.org Sun Feb 11 13:57:16 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 55AA4F1A5F6; Sun, 11 Feb 2018 13:57:16 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from tensor.andric.com (tensor.andric.com [87.251.56.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "tensor.andric.com", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D8CB479508; Sun, 11 Feb 2018 13:57:15 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from coleburn.home.andric.com (coleburn.home.andric.com [192.168.0.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id AAC681DFDD; Sun, 11 Feb 2018 14:57:08 +0100 (CET) From: Dimitry Andric Message-Id: <83191F81-4D50-4B7D-918D-963CC8A0F331@FreeBSD.org> Content-Type: multipart/signed; boundary="Apple-Mail=_72B1D30F-D38F-459A-A74A-F4651EE3F99D"; protocol="application/pgp-signature"; micalg=pgp-sha1 Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: Re: svn commit: r328973 - in stable/11: include sys/sys Date: Sun, 11 Feb 2018 14:57:07 +0100 In-Reply-To: Cc: Antoine Brodin , src-committers , svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org, re To: Hans Petter Selasky References: <201802071506.w17F6s5l043163@repo.freebsd.org> X-Mailer: Apple Mail (2.3273) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Feb 2018 13:57:16 -0000 --Apple-Mail=_72B1D30F-D38F-459A-A74A-F4651EE3F99D Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii On 11 Feb 2018, at 11:24, Hans Petter Selasky wrote: >=20 > On 02/11/18 11:09, Antoine Brodin wrote: >> On Sun, Feb 11, 2018 at 8:01 AM, Antoine Brodin = wrote: >>> On Wed, Feb 7, 2018 at 4:06 PM, Hans Petter Selasky >>> wrote: >>>> Author: hselasky >>>> Date: Wed Feb 7 15:06:54 2018 >>>> New Revision: 328973 >>>> URL: https://svnweb.freebsd.org/changeset/base/328973 >>>>=20 >>>> Log: >>>> MFC r328237: >>>> Use the __alloc_size2 attribute where relevant. >>>>=20 >>>> This follows the documented use in GCC. It is basically only = relevant for >>>> calloc(3), reallocarray(3) and mallocarray(9). >>>>=20 >>>> NOTE: Without this change clang 5.0.1 can produce incorrect = optimisation >>>> code for static processing of data using the allocated object. = For example >>>> this has been seen compiling the mlx4 core module, which = allocates a >>>> fixed size array which is then sorted by a fixed order loop. The >>>> optimised result, -O2, is incorrect unless this patch is in = place. >>>>=20 >>>> Suggested by: Mark Millard >>>> Reference: = https://docs.freebsd.org/cgi/mid.cgi?9DE674C6-EAA3-4E8A-906F-446E74D82FC4 >>>>=20 >>>> Modified: >>>> stable/11/include/stdlib.h >>>> stable/11/sys/sys/malloc.h >>>> Directory Properties: >>>> stable/11/ (props changed) >>>=20 >>> Hi, >>>=20 >>> Please revert this change. Lots of ports that used to build fine on >>> stable/11 are now failing. >>> /usr/include/stdlib.h:93:7: error: expected function body after >>> function declarator >>> __alloc_size2(1, 2); >=20 > Hi Antoine, >=20 > I'm sorry for the inconvenience. Probably I should have sent this = patch for portmgr first, to avoid such breakage. This patch is required = also for ports, and it is good you are now rebuilding ports which use = this define, because they might be broken due to the fact the = __alloc_size2() was incorrectly implemented! >=20 > I hope this will be the end of the breakage: >=20 > https://svnweb.freebsd.org/changeset/base/329122 Hmm, so you add something to the lint path, and that suddenly fixes the = builds? How is that possible? Are all these ports compiled in "lint = mode"? -Dimitry --Apple-Mail=_72B1D30F-D38F-459A-A74A-F4651EE3F99D Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.2 iF0EARECAB0WIQR6tGLSzjX8bUI5T82wXqMKLiCWowUCWoBLswAKCRCwXqMKLiCW o5RBAKDwFd8KBmE6f2Cydy8fFusUEwnHcACgwpPteMH/XmpJHZzOfNPHJxIX14s= =uP8l -----END PGP SIGNATURE----- --Apple-Mail=_72B1D30F-D38F-459A-A74A-F4651EE3F99D--