From owner-cvs-all Fri Dec 13 14:38:34 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0EB2A37B406 for ; Fri, 13 Dec 2002 14:38:33 -0800 (PST) Received: from mail.speakeasy.net (mail11.speakeasy.net [216.254.0.211]) by mx1.FreeBSD.org (Postfix) with ESMTP id D2A2543EDC for ; Fri, 13 Dec 2002 14:38:31 -0800 (PST) (envelope-from jhb@FreeBSD.org) Received: (qmail 15128 invoked from network); 13 Dec 2002 22:38:40 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) by mail11.speakeasy.net (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP for ; 13 Dec 2002 22:38:40 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.6/8.12.6) with ESMTP id gBDMcTuH073724; Fri, 13 Dec 2002 17:38:29 -0500 (EST) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.2 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <20021213220550.2BB132A8A5@canning.wemm.org> Date: Fri, 13 Dec 2002 17:38:32 -0500 (EST) From: John Baldwin To: Peter Wemm Subject: Re: cvs commit: src/sys/kern kern_descrip.c Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org, "Tim J. Robbins" Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 13-Dec-2002 Peter Wemm wrote: > "Tim J. Robbins" wrote: >> tjr 2002/12/13 01:59:40 PST >> >> Modified files: >> sys/kern kern_descrip.c >> Log: >> Drop filedesc lock and acquire Giant around calls to malloc() and free(). >> These call uma_large_malloc() and uma_large_free() which require Giant. >> Fixes panic when descriptor table is larger than KMEM_ZMAX bytes >> noticed by kkenn. > > What about things like geom which explicitly call malloc without Giant? > Or is it just a problem for large allocations? Just for large allocations which call uma_malloc_large(). -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message