From nobody Mon Aug 1 05:42:23 2022 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Lx6TG46Dkz4XTlk for ; Mon, 1 Aug 2022 05:42:26 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from omta001.cacentral1.a.cloudfilter.net (omta001.cacentral1.a.cloudfilter.net [3.97.99.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Lx6TF4Trqz3Bw5; Mon, 1 Aug 2022 05:42:25 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from shw-obgw-4004a.ext.cloudfilter.net ([10.228.9.227]) by cmsmtp with ESMTP id IBoeo2K2mS8WrIOC9o4h6v; Mon, 01 Aug 2022 05:42:25 +0000 Received: from spqr.komquats.com ([70.66.148.124]) by cmsmtp with ESMTPA id IOC8oOuxbGRNlIOC8onvLd; Mon, 01 Aug 2022 05:42:25 +0000 X-Authority-Analysis: v=2.4 cv=Sfrky9du c=1 sm=1 tr=0 ts=62e767c1 a=Cwc3rblV8FOMdVN/wOAqyQ==:117 a=Cwc3rblV8FOMdVN/wOAqyQ==:17 a=kj9zAlcOel0A:10 a=RgO8CyIxsXoA:10 a=VxmjJ2MpAAAA:8 a=YxBL1-UpAAAA:8 a=6I5d2MoRAAAA:8 a=EkcXrb_YAAAA:8 a=qJ9zPOUSs3Md8CwgmmYA:9 a=CjuIK1q_8ugA:10 a=tuWILHVPEjkA:10 a=7gXAzLPJhVmCkEl4_tsf:22 a=Ia-lj3WSrqcvXOmTRaiG:22 a=IjZwj45LgO3ly-622nXo:22 a=LK5xJRSDVpKd5WXXoEvA:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTP id C304810D; Sun, 31 Jul 2022 22:42:23 -0700 (PDT) Received: by slippy.cwsent.com (Postfix, from userid 1000) id 9624010C; Sun, 31 Jul 2022 22:42:23 -0700 (PDT) X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.7+dev Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Mark Johnston , freebsd-current@freebsd.org, chuck@freebsd.org, mhorne@FreeBSD.org, allanjude@FreeBSD.org Subject: Re: DTrace Error In-reply-to: <20220725153706.A2BB3A6@slippy.cwsent.com> References: <20220723035223.57CDBD7@slippy.cwsent.com> <20220723141444.85620189@slippy.cwsent.com> <20220723185533.9EA7D11E@slippy.cwsent.com> <20220724030857.B57FAFC@slippy.cwsent.com> <20220724170719.139BB40F@slippy.cwsent.com> <20220725153706.A2BB3A6@slippy.cwsent.com> Comments: In-reply-to Cy Schubert message dated "Mon, 25 Jul 2022 08:37:06 -0700." List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Sun, 31 Jul 2022 22:42:23 -0700 Message-Id: <20220801054223.9624010C@slippy.cwsent.com> X-CMAE-Envelope: MS4xfA9NRc5I+4uErD+95H8QGX9PvAOvBSUYKo1lUUT2aaUsc6KFhCittO228i++3krLrzZQG4/EWWuipnYxeeNzFVy5ETF/2fdfAZdPzHpqNaeHOhG5Kljn iaUssq1BUCCUgBqUM3r1OBg/vhjWOtq1dPdB8TL7fhhA9XJsq51OfEf0W7wR4tj0VsPe8SSOLQ36VpMxwo5lw8SH+MaKw55FWlPTEFrqoiXyR4QliyeV7WJ0 7zsGxW5AcVvLMwnkGgav8VsMQX1UZW7YWgDIkxG7B0sAfWS69FO5HRkwvW25G9hHCE4XYMGQ9deHQG6ahkTqO66a6iSW9II9pxD1ciRp+Wg= X-Rspamd-Queue-Id: 4Lx6TF4Trqz3Bw5 X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of cy.schubert@cschubert.com has no SPF policy when checking 3.97.99.32) smtp.mailfrom=cy.schubert@cschubert.com X-Spamd-Result: default: False [-1.80 / 15.00]; AUTH_NA(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-0.998]; MV_CASE(0.50)[]; RCVD_IN_DNSWL_MED(-0.20)[3.97.99.32:from]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; R_SPF_NA(0.00)[no SPF record]; MLMMJ_DEST(0.00)[freebsd-current@freebsd.org]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; RCPT_COUNT_FIVE(0.00)[5]; HAS_REPLYTO(0.00)[Cy.Schubert@cschubert.com]; ARC_NA(0.00)[]; REPLYTO_EQ_FROM(0.00)[]; RCVD_COUNT_FIVE(0.00)[5]; RCVD_VIA_SMTP_AUTH(0.00)[]; ASN(0.00)[asn:16509, ipnet:3.96.0.0/15, country:US]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_SOME(0.00)[]; DMARC_NA(0.00)[cschubert.com: no valid DMARC record]; RCVD_TLS_LAST(0.00)[] X-ThisMailContainsUnwantedMimeParts: N In message <20220725153706.A2BB3A6@slippy.cwsent.com>, Cy Schubert writes: > In message , Mark Johnston writes: > > On Sun, Jul 24, 2022 at 10:07:19AM -0700, Cy Schubert wrote: > > > In message <20220724030857.B57FAFC@slippy.cwsent.com>, Cy Schubert writes > : > > > > In message <20220723185533.9EA7D11E@slippy.cwsent.com>, Cy Schubert wri > te > > s: > > > > > In message , Mark Johnston writes: > > > > > > On Sat, Jul 23, 2022 at 07:14:44AM -0700, Cy Schubert wrote: > > > > > > > In message <20220723035223.57CDBD7@slippy.cwsent.com>, Cy Schuber > t > > writ > > > > es > > > > > : > > > > > > > > I'm not sure if this is because my obj tree needs a fresh rebui > ld > > and > > > > > > > > > > > > reinstall or if this is a legitimate problem. Regardless of the > d > > trac > > > > e > > > > > > > > command entered, whether it be a fbt or sdt, the following erro > r > > occu > > > > rs > > > > > : > > > > > > > > > > > > > > > > slippy# dtrace -n 'fbt::ieee80211_vap_setup:entry { printf("ent > er > > ing > > > > > > > > ieee80211_vap_setup\n"); }' > > > > > > > > dtrace: invalid probe specifier fbt::ieee80211_vap_setup:entry > { > > > > > > > > printf("entering ieee80211_vap_setup\n"); }: "/usr/lib/dtrace/p > si > > nfo. > > > > d" > > > > > , > > > > > > > > line 1: failed to copy type of 'pr_gid': Conflicting type is al > re > > ady > > > > de > > > > > fi > > > > > > ned > > > > > > > > slippy# > > > > > > > > > > > > > > > > Old DTrace scripts I've used months or even years ago also fail > w > > ith > > > > th > > > > > e > > > > > > > > same error. It's not this one probe. All probes result in the p > r_ > > gid > > > > er > > > > > ro > > > > > > r. > > > > > > > > > > > > > > > > I'm currently rebuilding my "prod" tree from scratch with the h > op > > e th > > > > at > > > > > > > > > > > > > it's simply something out of sync. But, should it not be, has a > ny > > one > > > > el > > > > > se > > > > > > > > > > > > > > encountered this lately? > > > > > > > > > > > > > > A full clean rebuild and installworld/kernel did not change the r > es > > ult. > > > > > > > > > > > This is a new problem. > > > > > > > > > > > > I don't see any such problem on a system built from commit 151abc80 > cd > > e, > > > > > > using GENERIC. Are you using a custom kernel config? Which kernel > > > > > > modules do you have loaded? > > > > > > > > > > [...] > > > > > > > > chuck@ emailed me privately suggesting a roll back to cb2ae6163174. The > > > > > problem is fixed. I'm creating a special branch that reverts only the l > lv > > m > > > > commits since then. > > > > > > llvm 14 is not the problem. There must be something else after cb2ae61631 > 74 > > > > > that is causing the regression. > > > > Are you able to bisect? I spent a bit of time trying to replicate the > > problem based on your kernel config, without any luck yet. > > How fortuitous is this email. I just rebooted my sandbox again and > discovered this is related to non-INVARIANT kernels. Enabling INVARIANTS > "fixes" dtrace. There must be some commit since cb2ae6163174 that affected > non-INVARIANT kernels. As to which one, I'm not sure yet. The commit that introduced the regression to non-INVARIANT kernels is 2449b9e5fe565be757a4b29093fd1c9c6ffcf3c9. Looking at the diff I don't see how it caused the problem but reverting it locally addresses the regression. (Of course one needs to disable building the mac_ddb module in order to have the build succeed.) Without looking at it closer, I suspect that dtrace could be sensitive to one of the struct changes. -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org NTP: Web: https://nwtime.org e**(i*pi)+1=0