From owner-p4-projects@FreeBSD.ORG Tue Jul 10 15:41:08 2007 Return-Path: X-Original-To: p4-projects@freebsd.org Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id D249016A474; Tue, 10 Jul 2007 15:41:07 +0000 (UTC) X-Original-To: perforce@FreeBSD.org Delivered-To: perforce@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 72C7D16A46E; Tue, 10 Jul 2007 15:41:07 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mxout2.cac.washington.edu (mxout2.cac.washington.edu [140.142.33.4]) by mx1.freebsd.org (Postfix) with ESMTP id 5069313C4B9; Tue, 10 Jul 2007 15:41:07 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from smtp.washington.edu (smtp.washington.edu [140.142.33.9] (may be forged)) by mxout2.cac.washington.edu (8.13.7+UW06.06/8.13.7+UW07.06) with ESMTP id l6AFf6H0024396 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 10 Jul 2007 08:41:07 -0700 X-Auth-Received: from [192.168.10.45] (c-24-10-12-194.hsd1.ca.comcast.net [24.10.12.194]) (authenticated authid=youshi10) by smtp.washington.edu (8.13.7+UW06.06/8.13.7+UW07.03) with ESMTP id l6AFf66e023644 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Tue, 10 Jul 2007 08:41:06 -0700 Message-ID: <4693A891.90601@gmail.com> Date: Tue, 10 Jul 2007 08:41:05 -0700 From: Garrett Cooper User-Agent: Thunderbird 2.0.0.4 (Windows/20070604) MIME-Version: 1.0 To: Matus Harvan References: <200707100940.l6A9el1D040230@repoman.freebsd.org> In-Reply-To: <200707100940.l6A9el1D040230@repoman.freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-PMX-Version: 5.3.2.304607, Antispam-Engine: 2.5.1.298604, Antispam-Data: 2007.7.10.82432 X-Uwash-Spam: Gauge=IIIIIII, Probability=7%, Report='FORGED_FROM_GMAIL 0.1, __CP_URI_IN_BODY 0, __CT 0, __CTE 0, __CT_TEXT_PLAIN 0, __FROM_GMAIL 0, __HAS_MSGID 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __SANE_MSGID 0, __USER_AGENT 0' Cc: Perforce Change Reviews Subject: Re: PERFORCE change 123260 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Jul 2007 15:41:08 -0000 Matus Harvan wrote: > http://perforce.freebsd.org/chv.cgi?CH=123260 > > Change 123260 by mharvan@mharvan_twoflower on 2007/07/10 09:39:53 > > use #ifdef to run the proper ifconfig commands on FreeBSD and Linux > > Affected files ... > > .. //depot/projects/soc2007/mharvan-mtund/mtund.src/tunneld.c#7 edit > > Differences ... > > ==== //depot/projects/soc2007/mharvan-mtund/mtund.src/tunneld.c#7 (text+ko) ==== > > @@ -418,13 +418,19 @@ > > /* setup the tun interface */ > if (server) { > - system("ifconfig tun0 mtu 1400 192.168.0.1 192.168.0.2"); > + #ifdef __FreeBSD__ > + ssystem("ifconfig tun0 mtu 1400 192.168.0.1 192.168.0.2"); > + #endif > + > } else { > /* FeeBSD */ > I believe that comment's a typo. Thanks, -Garrett