From owner-freebsd-bugs@FreeBSD.ORG Thu Feb 18 23:30:04 2010 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 02E10106566C for ; Thu, 18 Feb 2010 23:30:04 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id DB64E8FC17 for ; Thu, 18 Feb 2010 23:30:03 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id o1INU31R084247 for ; Thu, 18 Feb 2010 23:30:03 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id o1INU3Fl084244; Thu, 18 Feb 2010 23:30:03 GMT (envelope-from gnats) Date: Thu, 18 Feb 2010 23:30:03 GMT Message-Id: <201002182330.o1INU3Fl084244@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: Garrett Cooper Cc: Subject: Re: conf/144079: Makefile.inc1 ${DESTDIR} make dependency enhancement X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Garrett Cooper List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Feb 2010 23:30:04 -0000 The following reply was made to PR conf/144079; it has been noted by GNATS. From: Garrett Cooper To: bug-followup@FreeBSD.org, gcooper@FreeBSD.org Cc: Subject: Re: conf/144079: Makefile.inc1 ${DESTDIR} make dependency enhancement Date: Thu, 18 Feb 2010 15:23:42 -0800 --000e0cd138b8f6be63047fe8410f Content-Type: text/plain; charset=ISO-8859-1 The patch on the right track, but wasn't complete, so I had to be a bit more invasive with where the DESTDIR dependencies went (filled in all missing dependencies based on inspection) and where the goal itself goes (bsd.own.mk). I'm not happy about the placement of the goal, and I'm open to move it to another location if one exists, as bsd.own.mk seems to be purely variable driven data setting without goals. Thanks, -Garrett --000e0cd138b8f6be63047fe8410f Content-Type: text/plain; charset=US-ASCII; name="destdir-installcheck.diff.txt" Content-Disposition: attachment; filename="destdir-installcheck.diff.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_g5u6gurw1 SW5kZXg6IGV0Yy9NYWtlZmlsZQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBldGMvTWFrZWZpbGUJKHJldmlzaW9u IDIwNDAyNykKKysrIGV0Yy9NYWtlZmlsZQkod29ya2luZyBjb3B5KQpAQCAtMTQ4LDcgKzE0OCw3 IEBACiBQV0RfTUtEQl9FTkRJQU4/PQogLmVuZGlmCiAKLWRpc3RyaWJ1dGlvbjoKK2Rpc3RyaWJ1 dGlvbjogJHtERVNURElSfQogLmlmICFkZWZpbmVkKERFU1RESVIpCiAJQGVjaG8gInNldCBERVNU RElSIGJlZm9yZSBydW5uaW5nIFwibWFrZSAkey5UQVJHRVR9XCIiCiAJQGZhbHNlCkBAIC0yNTIs NyArMjUyLDcgQEAKIAkgICAgJHtERVNURElSfS9ib290L2RldmljZS5oaW50cwogLmVuZGlmCiAK LWRpc3RyaWItZGlyczoKK2Rpc3RyaWItZGlyczogJHtERVNURElSfQogCW10cmVlIC1lVSAke01U UkVFX0ZPTExPV1NfU1lNTElOS1N9IC1mICR7LkNVUkRJUn0vbXRyZWUvQlNELnJvb3QuZGlzdCAt cCAke0RFU1RESVJ9LwogCW10cmVlIC1lVSAke01UUkVFX0ZPTExPV1NfU1lNTElOS1N9IC1mICR7 LkNVUkRJUn0vbXRyZWUvQlNELnZhci5kaXN0IC1wICR7REVTVERJUn0vdmFyCiAJbXRyZWUgLWVV ICR7TVRSRUVfRk9MTE9XU19TWU1MSU5LU30gLWYgJHsuQ1VSRElSfS9tdHJlZS9CU0QudXNyLmRp c3QgLXAgJHtERVNURElSfS91c3IKQEAgLTI5OCw3ICsyOTgsNyBAQAogCQlzaGlmdDsgc2hpZnQ7 IFwKIAlkb25lCiAKLWV0Yy1leGFtcGxlczoKK2V0Yy1leGFtcGxlczogJHtERVNURElSfQogCWNk ICR7LkNVUkRJUn07ICR7SU5TVEFMTH0gLW8gJHtCSU5PV059IC1nICR7QklOR1JQfSAtbSA0NDQg XAogCSAgICAke0JJTjF9ICR7QklOMn0gbnNtYi5jb25mIG9waWVhY2Nlc3MgXAogCSAgICAke0RF U1RESVJ9L3Vzci9zaGFyZS9leGFtcGxlcy9ldGMKSW5kZXg6IGluY2x1ZGUvTWFrZWZpbGUKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gaW5jbHVkZS9NYWtlZmlsZQkocmV2aXNpb24gMjA0MDI3KQorKysgaW5jbHVk ZS9NYWtlZmlsZQkod29ya2luZyBjb3B5KQpAQCAtMTI1LDcgKzEyNSw3IEBACiAke1NIQVJFRH06 IGNvbXBhdAogCiAjIFRha2UgY2FyZSBvZiBzdGFsZSBkaXJlY3RvcnktbGV2ZWwgc3ltbGlua3Mu Ci1jb21wYXQ6Citjb21wYXQ6ICR7REVTVERJUn0KIC5mb3IgaSBpbiAke0xESVJTfSAke0xTVUJE SVJTfSBtYWNoaW5lICR7X01BUkNIfSBjcnlwdG8KIAlpZiBbIC1MICR7REVTVERJUn0ke0lOQ0xV REVESVJ9LyRpIF07IHRoZW4gXAogCQlybSAtZiAke0RFU1RESVJ9JHtJTkNMVURFRElSfS8kaTsg XApAQCAtMTQwLDcgKzE0MCw3IEBACiAJICAgIC1wICR7REVTVERJUn0ke0lOQ0xVREVESVJ9CiAu ZW5kaWYKIAotY29waWVzOgorY29waWVzOiAke0RFU1RESVJ9CiAuZm9yIGkgaW4gJHtMRElSU30g JHtMU1VCRElSU30gJHtMU1VCU1VCRElSU30gYWx0cSBjcnlwdG8gbWFjaGluZSBtYWNoaW5lL3Bj IFwKIAkke19NQVJDSH0KIC5pZiBleGlzdHMoJHtERVNURElSfSR7SU5DTFVERURJUn0vJGkpCkBA IC0yMDcsNyArMjA3LDcgQEAKIAkke0lOU1RBTEx9IC1DIC1vICR7QklOT1dOfSAtZyAke0JJTkdS UH0gLW0gNDQ0IHR5cGVzLmggXAogCSAgICAke0RFU1RESVJ9JHtJTkNMVURFRElSfS9ycGMKIAot c3ltbGlua3M6CitzeW1saW5rczogJHtERVNURElSfQogCUAke0VDSE99ICJTZXR0aW5nIHVwIHN5 bWxpbmtzIHRvIGtlcm5lbCBzb3VyY2UgdHJlZS4uLiIKIC5mb3IgaSBpbiAke0xESVJTfQogCWNk ICR7LkNVUkRJUn0vLi4vc3lzLyRpOyBcCkluZGV4OiBzaGFyZS9tay9ic2Qub3duLm1rCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIHNoYXJlL21rL2JzZC5vd24ubWsJKHJldmlzaW9uIDIwNDAyNykKKysrIHNoYXJl L21rL2JzZC5vd24ubWsJKHdvcmtpbmcgY29weSkKQEAgLTU0MSw2ICs1NDEsMTcgQEAKIC5lbmRp ZgogLmVuZGZvcgogCisjCisjIEEgcmVhbCB0YXJnZXQgd2hpY2ggY29ycmVzcG9uZHMgdG8gJHtE RVNURElSfS4gVGhpcyBpcyBvdXRzaWRlIG9mIHRoZQorIyBkaXN0cmlidXRld29ybGQgY2hlY2sg YmVsb3cgYmVjYXVzZSBhKSBpdCdzIGEgbm8tb3AsIGFuZCBiKSBpdCBjb3VsZCBiZSBhCisjIG1h a2UgZGVwZW5kZW5jeSBvZiBhbm90aGVyIHRhcmdldCBlbHNld2hlcmUuCisjCisjIFRoZSBkZWZp bmVkICYmICFlbXB0eSBjaGVjayBpcyBmb3IgY29tcGxldGVuZXNzIHRvIGVuc3VyZSB0aGF0IG1r ZGlyIC1wICIiCisjIGlzbid0IGludm9rZWQgKHdoaWNoIHdvdWxkIHJlc3VsdCBpbiBhbiBlcnJv cikuCisjCiske0RFU1RESVJ9OgorCW1rZGlyIC1wICIkey5UQVJHRVR9IgorCiAuZW5kaWYgIyAh X1dJVEhPVVRfU1JDQ09ORgogCiAuZW5kaWYJIyAhdGFyZ2V0KF9fPGJzZC5vd24ubWs+X18pCklu ZGV4OiBzeXMvbW9kdWxlcy9NYWtlZmlsZQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBzeXMvbW9kdWxlcy9NYWtl ZmlsZQkocmV2aXNpb24gMjA0MDI3KQorKysgc3lzL21vZHVsZXMvTWFrZWZpbGUJKHdvcmtpbmcg Y29weSkKQEAgLTYzNSw3ICs2MzUsNyBAQAogIyBDYWxsaW5nIGtsZHhyZWYoOCkgZm9yIGVhY2gg bW9kdWxlIGlzIGV4cGVuc2l2ZS4KIC5pZiAhZGVmaW5lZChOT19YUkVGKQogLk1BS0VGTEFHUys9 CS1ETk9fWFJFRgotYWZ0ZXJpbnN0YWxsOgorYWZ0ZXJpbnN0YWxsOiAke0RFU1RESVJ9CiAJQGlm IHR5cGUga2xkeHJlZiA+L2Rldi9udWxsIDI+JjE7IHRoZW4gXAogCQkke0VDSE99IGtsZHhyZWYg JHtERVNURElSfSR7S01PRERJUn07IFwKIAkJa2xkeHJlZiAke0RFU1RESVJ9JHtLTU9ERElSfTsg XAo= --000e0cd138b8f6be63047fe8410f--