From owner-svn-src-all@FreeBSD.ORG Fri Dec 14 04:31:03 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 9F41BB40 for ; Fri, 14 Dec 2012 04:31:03 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-la0-f54.google.com (mail-la0-f54.google.com [209.85.215.54]) by mx1.freebsd.org (Postfix) with ESMTP id 0C7BF8FC14 for ; Fri, 14 Dec 2012 04:31:02 +0000 (UTC) Received: by mail-la0-f54.google.com with SMTP id j13so2407594lah.13 for ; Thu, 13 Dec 2012 20:31:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=640rnusHD/pw2rtGMTBfIN+9YVYgLQgT8luyfD89wek=; b=qytBxeiCONRJqAd/hl06FnH3vifTv3vHarYdx3RR/Iv05IlYNor77eyXXUi+TAukQq Znv1BB6omL+IlZx0Hw+VS1DUjo7Xkl8o/7WGBHpUCJFdl02jdEPkd/ipEeYqO6oRUNxj wtoBTEDFK4/gqASNT67CejY7MpjvT1Fj4WuCI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :x-gm-message-state; bh=640rnusHD/pw2rtGMTBfIN+9YVYgLQgT8luyfD89wek=; b=jijmv1yQ3aS+GAeszoCLoaQRTbSJBYcren02Br7mKuiiHTilV45P/th6v3k2GJLVb2 Uf6vh2HO05eYXdOxYc5s2G3zIIkI/f9cEU+QTBvj19uAx6/C0ZnxRqTk8mnniOaHpcuc A2OyHyFIWNak2SvHPPGaU84ZiulXH/zCmrARlHebGmP+1ZWBSWxCQaOCqOUdP2I1tAw5 BoeCZ2fx4BHEVKAqnypOaAfdyObkui8R4/SGEqm4z0XdvaTzdyjeCRTD/XnOnSu7VeGn FCIbVt5cNxI9a20nb8G4Ycrv59MFtqEpdWjP6p9MQ+KpgiBnXIqvWxvAwkbKyEZDTB3x O4gA== Received: by 10.112.13.133 with SMTP id h5mr1717366lbc.99.1355459461590; Thu, 13 Dec 2012 20:31:01 -0800 (PST) MIME-Version: 1.0 Sender: lists@eitanadler.com Received: by 10.112.149.225 with HTTP; Thu, 13 Dec 2012 20:30:31 -0800 (PST) In-Reply-To: <20121213181621.GG71906@kib.kiev.ua> References: <201212121545.qBCFj4Hl086444@svn.freebsd.org> <20121212210652.GO3013@kib.kiev.ua> <20121213111240.GB1381@garage.freebsd.pl> <20121213161242.GE71906@kib.kiev.ua> <20121213165541.GD1381@garage.freebsd.pl> <20121213181621.GG71906@kib.kiev.ua> From: Eitan Adler Date: Thu, 13 Dec 2012 23:30:31 -0500 X-Google-Sender-Auth: 95dwn3CxHqyZmJklhWGjDCUkogM Message-ID: Subject: Re: svn commit: r244154 - head/bin/ps To: Konstantin Belousov Content-Type: text/plain; charset=UTF-8 X-Gm-Message-State: ALoCoQnoHGaf8vekbk0v3RyQE/0rZ2RZTiuQUZpBaYGD0+1aRl0c07bi0HDaemIfgeY4ARI5kOA6 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Pawel Jakub Dawidek , jhb@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Dec 2012 04:31:03 -0000 On 13 December 2012 13:16, Konstantin Belousov wrote: > On Thu, Dec 13, 2012 at 05:55:41PM +0100, Pawel Jakub Dawidek wrote: >> On Thu, Dec 13, 2012 at 06:12:42PM +0200, Konstantin Belousov wrote: >> > On Thu, Dec 13, 2012 at 12:12:44PM +0100, Pawel Jakub Dawidek wrote: >> > > On Wed, Dec 12, 2012 at 11:06:52PM +0200, Konstantin Belousov wrote: >> > > I saw CTLFLAG_TUN on the sysctl and assumed it is read-only... >> > > How about defining BSD_PID_MAX in sys/proc.h, which would be visible by >> > > userland as well and setting PID_MAX to BSD_PID_MAX? >> > > >> > > This would also help bsnmpd. >> > > >> > > http://people.freebsd.org/~pjd/patches/PID_MAX.patch >> > Do you know why PID_MAX is under _KERNEL ? If there is no real reason, >> > it would be better to move it outside kernel-only section. sys/proc.h >> > is not in POSIX anyway. >> >> I assumed it will break some ports that may define it themselves. >> I wonder if we could do a test ports build to see what's the impact. > > Sure. > > On the other hand, sys/proc.h is mostly useless for the application code > as it is now. Might be, use > #ifndef PID_MAX > braces ? I think it makes more sense to unconditionally define it. A file including sys/proc.h almost certainly wants the real PID_MAX. It would be better to cause a pre-process time failure than to have it silently hide the problem. -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams