From owner-cvs-all@FreeBSD.ORG  Tue Nov 30 22:28:50 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id D0A3416A4CE; Tue, 30 Nov 2004 22:28:50 +0000 (GMT)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id BFD9043D31; Tue, 30 Nov 2004 22:28:50 +0000 (GMT)
	(envelope-from mlaier@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id iAUMSoeT028700;
	Tue, 30 Nov 2004 22:28:50 GMT
	(envelope-from mlaier@repoman.freebsd.org)
Received: (from mlaier@localhost)
	by repoman.freebsd.org (8.13.1/8.13.1/Submit) id iAUMSoQC028699;
	Tue, 30 Nov 2004 22:28:50 GMT
	(envelope-from mlaier)
Message-Id: <200411302228.iAUMSoQC028699@repoman.freebsd.org>
From: Max Laier <mlaier@FreeBSD.org>
Date: Tue, 30 Nov 2004 22:28:50 +0000 (UTC)
To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org,
	cvs-all@FreeBSD.org
X-FreeBSD-CVS-Branch: HEAD
Subject: cvs commit: src/sys/netgraph
	ng_socket.csrc/sys/netgraph/bluetooth/socket ng_btsocket.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 30 Nov 2004 22:28:51 -0000

mlaier      2004-11-30 22:28:50 UTC

  FreeBSD src repository

  Modified files:
    sys/netgraph         ng_socket.c 
    sys/netgraph/bluetooth/socket ng_btsocket.c 
  Log:
  Move ng_socket and ng_btsocket initialization to SI_SUB_PROTO_DOMAIN as they
  call net_add_domain(). Calling this function too early (or late) breaks
  assertations about the global domains list.
  Actually it should be forbidden to call net_add_domain() outside of
  SI_SUB_PROTO_DOMAIN completely as there are many places where we traverse
  the domains list unprotected, but for now we allow late calls (mostly to
  support netgraph). In order to really fix this we have to lock the domains
  list in all places or find another way to ensure that we can safely walk the
  list while another thread might be adding a new domain.
  
  Spotted by:     se
  Reviewed by:    julian, glebius
  PR:             kern/73321      (partly)
  
  Revision  Changes    Path
  1.9       +2 -1      src/sys/netgraph/bluetooth/socket/ng_btsocket.c
  1.56      +1 -1      src/sys/netgraph/ng_socket.c