From owner-freebsd-ports-bugs@FreeBSD.ORG Tue Nov 23 09:20:12 2010 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7AB031065670 for ; Tue, 23 Nov 2010 09:20:12 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 3D7818FC19 for ; Tue, 23 Nov 2010 09:20:12 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id oAN9KCXj069453 for ; Tue, 23 Nov 2010 09:20:12 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id oAN9KCqQ069452; Tue, 23 Nov 2010 09:20:12 GMT (envelope-from gnats) Resent-Date: Tue, 23 Nov 2010 09:20:12 GMT Resent-Message-Id: <201011230920.oAN9KCqQ069452@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, KOIE Hidetaka Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D5E3C1065674 for ; Tue, 23 Nov 2010 09:13:56 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (unknown [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id C4FB08FC14 for ; Tue, 23 Nov 2010 09:13:56 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id oAN9Duss015622 for ; Tue, 23 Nov 2010 09:13:56 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id oAN9DuW5015620; Tue, 23 Nov 2010 09:13:56 GMT (envelope-from nobody) Message-Id: <201011230913.oAN9DuW5015620@red.freebsd.org> Date: Tue, 23 Nov 2010 09:13:56 GMT From: KOIE Hidetaka To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/152524: hald runs busy after devd stopped. X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Nov 2010 09:20:12 -0000 >Number: 152524 >Category: ports >Synopsis: hald runs busy after devd stopped. >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Nov 23 09:20:11 UTC 2010 >Closed-Date: >Last-Modified: >Originator: KOIE Hidetaka >Release: 9.0-CURRENT >Organization: surigiken >Environment: FreeBSD guriandgura 9.0-CURRENT FreeBSD 9.0-CURRENT #0: Wed Nov 17 15:11:51 JST 2010 root@guriandgura:/usr/obj/museum/freebsd/sys/GURIANDGURA amd64 >Description: Usually devd does not stop, but hald comsumes CPU 100% after /etc/rc.d/devd stop or restart. >How-To-Repeat: /etc/rc.d/devd restart >Fix: In /usr/ports/sysutils/hal/work/hal-0.5.14/hald/freebsd/hf-devd.c, becasue hf_devd_event_cb() does not handle G_IO_STATUS_EOF event, the event loop runs forever. this patch stops the event storm. hald should re-connect to devd if devd restarts. Patch attached with submission follows: diff -rpu work/hal-0.5.14/hald/freebsd/hf-devd.c work.koie/hal-0.5.14/hald/freebsd/hf-devd.c --- work/hal-0.5.14/hald/freebsd/hf-devd.c 2009-08-24 21:42:29.000000000 +0900 +++ work.koie/hal-0.5.14/hald/freebsd/hf-devd.c 2010-11-23 17:07:55.507475429 +0900 @@ -412,6 +412,16 @@ hf_devd_event_cb (GIOChannel *source, GI return FALSE; } } + else if (status == G_IO_STATUS_EOF) + { + int fd; + + HAL_WARNING(("%s was disconnected", HF_DEVD_SOCK_PATH)); + fd = g_io_channel_unix_get_fd(source); + g_io_channel_shutdown(source, FALSE, NULL); + close(fd); + return FALSE; + } return TRUE; } >Release-Note: >Audit-Trail: >Unformatted: