From owner-freebsd-arch@FreeBSD.ORG  Fri May 11 00:35:01 2007
Return-Path: <owner-freebsd-arch@FreeBSD.ORG>
X-Original-To: arch@FreeBSD.org
Delivered-To: freebsd-arch@FreeBSD.ORG
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id D9D5916A402;
	Fri, 11 May 2007 00:35:01 +0000 (UTC)
	(envelope-from ache@nagual.pp.ru)
Received: from nagual.pp.ru (nagual.pp.ru [194.87.13.69])
	by mx1.freebsd.org (Postfix) with ESMTP id 5335413C44B;
	Fri, 11 May 2007 00:35:01 +0000 (UTC)
	(envelope-from ache@nagual.pp.ru)
Received: from nagual.pp.ru (ache@localhost [127.0.0.1])
	by nagual.pp.ru (8.14.1/8.14.1) with ESMTP id l4B0Yjs0006539;
	Fri, 11 May 2007 04:34:45 +0400 (MSD)
	(envelope-from ache@nagual.pp.ru)
Received: (from ache@localhost)
	by nagual.pp.ru (8.14.1/8.14.1/Submit) id l4B0YiRD006538;
	Fri, 11 May 2007 04:34:44 +0400 (MSD) (envelope-from ache)
Date: Fri, 11 May 2007 04:34:44 +0400
From: Andrey Chernov <ache@FreeBSD.org>
To: "Sean C. Farley" <sean-freebsd@farley.org>
Message-ID: <20070511003443.GA6422@nagual.pp.ru>
References: <20070504213312.GA33163@nagual.pp.ru>
	<20070504174657.D1343@thor.farley.org>
	<20070505213202.GA49925@nagual.pp.ru>
	<20070505163707.J6670@thor.farley.org>
	<20070505221125.GA50439@nagual.pp.ru>
	<20070506091835.A43775@besplex.bde.org>
	<20070508162458.G6015@baba.farley.org>
	<20070508222521.GA59534@nagual.pp.ru>
	<20070509200000.B56490@besplex.bde.org>
	<20070510184447.H4969@baba.farley.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20070510184447.H4969@baba.farley.org>
User-Agent: Mutt/1.5.15 (2007-04-06)
Cc: Daniel Eischen <deischen@FreeBSD.org>, arch@FreeBSD.org
Subject: Re: HEADS DOWN
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussion related to FreeBSD architecture <freebsd-arch.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 11 May 2007 00:35:01 -0000

On Thu, May 10, 2007 at 06:58:45PM -0500, Sean C. Farley wrote:
>  Would there be any other changes anybody can see need to be made?  What
>  type of testing would be desired?  The regression tests I wrote provide
>  a good basic test.

I worry about this sort of things
errx(EXIT_FAILURE, "environ corrupt");

There is no mention anywhere that *env() functions can exit the program.
Moreover some programs in theory can temprorarily put incorrect values 
into environment via putenv() after-modification or direct environ 
assignments for their own reasons.

I suggest to change errx() to warnx()+return(failure).

-- 
http://ache.pp.ru/