From owner-freebsd-bugs@FreeBSD.ORG Thu Dec 29 21:20:09 2011 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 218381065670 for ; Thu, 29 Dec 2011 21:20:09 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id F1E208FC0C for ; Thu, 29 Dec 2011 21:20:08 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id pBTLK8q5093619 for ; Thu, 29 Dec 2011 21:20:08 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id pBTLK8nt093618; Thu, 29 Dec 2011 21:20:08 GMT (envelope-from gnats) Resent-Date: Thu, 29 Dec 2011 21:20:08 GMT Resent-Message-Id: <201112292120.pBTLK8nt093618@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Dmitry Kazarov Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E2789106566B for ; Thu, 29 Dec 2011 21:13:57 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id B71DE8FC18 for ; Thu, 29 Dec 2011 21:13:57 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id pBTLDvf1037156 for ; Thu, 29 Dec 2011 21:13:57 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id pBTLDvkY037142; Thu, 29 Dec 2011 21:13:57 GMT (envelope-from nobody) Message-Id: <201112292113.pBTLDvkY037142@red.freebsd.org> Date: Thu, 29 Dec 2011 21:13:57 GMT From: Dmitry Kazarov To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: kern/163701: ifconfig: group parameter makes impossible to restart interface X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Dec 2011 21:20:09 -0000 >Number: 163701 >Category: kern >Synopsis: ifconfig: group parameter makes impossible to restart interface >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Thu Dec 29 21:20:08 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Dmitry Kazarov >Release: 8.2-STABLE >Organization: >Environment: FreeBSD Trudiaga.localdomain 8.2-STABLE FreeBSD 8.2-STABLE #0: Mon Dec 12 01:42:49 MSK 2011 root@Trudiaga.localdomain:/var/obj/usr/src/sys/GENERIC i386 >Description: If group parameter is specified in /etc/rc.conf it makes /etc/rc.d/netif restart to fail: # fgrep re0 /etc/rc.conf ifconfig_re0='192.168.1.20/24 group ifgrp' # ifconfig -v re0 re0: flags=8843 metric 0 mtu 1500 options=3898 ether 00:1f:d0:5e:8f:57 inet 192.168.1.20 netmask 0xffffff00 broadcast 192.168.1.255 media: Ethernet autoselect (1000baseT ) status: active groups: ifgrp # /etc/rc.d/netif restart re0 Stopping Network: re0. re0: flags=8802 metric 0 mtu 1500 options=3898 ether 00:1f:d0:5e:8f:57 media: Ethernet autoselect (none) status: no carrier ifconfig: SIOCAIFGROUP: File exists Starting Network: re0. re0: flags=8843 metric 0 mtu 1500 options=3898 ether 00:1f:d0:5e:8f:57 media: Ethernet autoselect (none) status: no carrier The source of problem is that groups parameter persist when interface goes down: # /etc/rc.d/netif stop re0 Stopping Network: re0. re0: flags=8802 metric 0 mtu 1500 options=3898 ether 00:1f:d0:5e:8f:57 media: Ethernet autoselect (1000baseT ) status: active # ifconfig -v re0 re0: flags=8802 metric 0 mtu 1500 options=3898 ether 00:1f:d0:5e:8f:57 media: Ethernet autoselect (1000baseT ) status: active groups: ifgrp IMHO it's better to just ignore error when group param specifies groupname to which interface is already assigned. >How-To-Repeat: >Fix: --- src/sbin/ifconfig/ifgroup.c.orig 2011-12-30 01:07:54.000000000 +0400 +++ src/sbin/ifconfig/ifgroup.c 2011-12-30 01:09:09.000000000 +0400 @@ -58,7 +58,10 @@ if (strlcpy(ifgr.ifgr_group, group_name, IFNAMSIZ) >= IFNAMSIZ) errx(1, "setifgroup: group name too long"); if (ioctl(s, SIOCAIFGROUP, (caddr_t)&ifgr) == -1) - err(1," SIOCAIFGROUP"); + if (errno == EEXIST) + return; + else + err(1," SIOCAIFGROUP"); } /* ARGSUSED */ >Release-Note: >Audit-Trail: >Unformatted: