Date: Wed, 3 Nov 2004 23:32:46 +0300 From: Gleb Smirnoff <glebius@freebsd.org> To: Luigi Rizzo <rizzo@icir.org> Cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/em if_em.c Message-ID: <20041103203246.GD5033@cell.sick.ru> In-Reply-To: <20041103082806.C49241@xorpc.icir.org> References: <200411031411.iA3EBIqL012134@repoman.freebsd.org> <418905E5.1050605@freebsd.org> <20041103082806.C49241@xorpc.icir.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Nov 03, 2004 at 08:28:06AM -0800, Luigi Rizzo wrote: L> > I think that in general we can start eyeing a lot of similar verbosity L> > in all of our drivers, both at boot and at runtime. For example most L> > nic drivers print out their MAC and all of their possible negotiation L> > rates on attach. This same info can be obtained from ifconfig. Why L> > clutter the boot with it? L> L> because sometimes you might need to enable some MAC-based filter L> before you have a chance to access the box. e.g. to set dhcp/bootp L> anbd the like. L> L> A bit of verbosity is useful, you can always switch to splash screens L> if you don't like them. L> L> I think the link-up/link-down thing is different because it L> happens not just at boot but also whenever the link status L> changes (e.g. when a spanning tree on a switch detects a L> reconfiguration), and this is annoying on the console. My 1 penny: I completely agree with Luigi at this point. So my vote is: keep initialization printfs as is, remove any runtime printfs. -- Totus tuus, Glebius. GLEBIUS-RIPN GLEB-RIPE
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20041103203246.GD5033>