From owner-cvs-all@FreeBSD.ORG  Sun Jan 11 09:09:50 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id C2F3A16A4CE
	for <cvs-all@FreeBSD.org>; Sun, 11 Jan 2004 09:09:50 -0800 (PST)
Received: from smtp.mho.com (smtp.mho.net [64.58.4.6])
	by mx1.FreeBSD.org (Postfix) with SMTP id 5C23943D45
	for <cvs-all@FreeBSD.org>; Sun, 11 Jan 2004 09:09:10 -0800 (PST)
	(envelope-from scottl@freebsd.org)
Received: (qmail 41875 invoked by uid 1002); 11 Jan 2004 17:09:09 -0000
Received: from unknown (HELO freebsd.org) (64.58.1.252)
  by smtp.mho.net with SMTP; 11 Jan 2004 17:09:09 -0000
Message-ID: <400182CE.4090101@freebsd.org>
Date: Sun, 11 Jan 2004 10:07:26 -0700
From: Scott Long <scottl@freebsd.org>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.5) Gecko/20031103
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: "David E. O'Brien" <obrien@FreeBSD.org>
References: <200401111030.i0BAUuVH037222@repoman.freebsd.org>
In-Reply-To: <200401111030.i0BAUuVH037222@repoman.freebsd.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/dev/sound/pci emu10k1.c
 src/sys/modules/sound/driver/emu10k1         Makefile
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 11 Jan 2004 17:09:50 -0000

David E. O'Brien wrote:
> obrien      2004/01/11 02:30:56 PST
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/dev/sound/pci    emu10k1.c 
>     sys/modules/sound/driver/emu10k1 Makefile 
>   Log:
>   Add Audigy support.
>   I started with a year-old patch by Orlando Bassotto
>   <orlando.bassotto@ieo-research.it>, and ported it to 5.2-CURRENT along with
>   fixing the problems working with pre-Audigy cards.
>   
>   Revision  Changes    Path
>   1.44      +521 -93   src/sys/dev/sound/pci/emu10k1.c
>   1.4       +11 -2     src/sys/modules/sound/driver/emu10k1/Makefile
> 

Besides the compilation problems that have been identified, we need to
talk about the license issues here.  Now that the driver is being
actively maintained again, we can't ignore the GPL contamination in
it.  It now relies on 3 header files that are explicitely licensed
unuder the GPL.  Even though emu10k1.c is explicitly licensed under
the BSDL, the headers brind GPL contamination to the resulting binary
module.  Since we strive to ship our GENERIC kernel free of GPL
components, and the emu10k1 module is part of the GENERIC kernel, we
have a problem.

Similar GPL contamination exists with the maestro3 driver, with the
result being that it doesn't get included into the kernel builds and
can only be loaded as a module.  We should seriously consider doing
the same for emu10k1 now.

Scott