From owner-freebsd-current  Thu Mar 23 17: 4: 3 2000
Delivered-To: freebsd-current@freebsd.org
Received: from fgwmail7.fujitsu.co.jp (fgwmail7.fujitsu.co.jp [192.51.44.37])
	by hub.freebsd.org (Postfix) with ESMTP id DF4E137C54B
	for <freebsd-current@FreeBSD.ORG>; Thu, 23 Mar 2000 17:03:54 -0800 (PST)
	(envelope-from shin@nd.net.fujitsu.co.jp)
Received: from m5.gw.fujitsu.co.jp by fgwmail7.fujitsu.co.jp (8.9.3/3.7W-MX0002-Fujitsu Gateway)
	id KAA03774; Fri, 24 Mar 2000 10:03:49 +0900 (JST)
	(envelope-from shin@nd.net.fujitsu.co.jp)
Received: from chisato.nd.net.fujitsu.co.jp by m5.gw.fujitsu.co.jp (8.9.3/3.7W-0003-Fujitsu Domain Master)
	id KAA24138; Fri, 24 Mar 2000 10:03:47 +0900 (JST)
Received: from localhost (dhcp7173.nd.net.fujitsu.co.jp [10.18.7.173]) by chisato.nd.net.fujitsu.co.jp (8.8.5+2.7Wbeta5/3.3W8chisato-970826) with ESMTP id KAA26448; Fri, 24 Mar 2000 10:03:46 +0900 (JST)
To: imp@village.org
Cc: dillon@apollo.backplane.com, ilmar@ints.ru, nms@otdel-1.org,
	freebsd-current@FreeBSD.ORG
Subject: Re: -current sudden panics :( 
In-Reply-To: <200003231921.MAA42799@harmony.village.org>
References: <200003222201.PAA33948@harmony.village.org>
	<20000323105025W.shin@nd.net.fujitsu.co.jp>
	<200003231921.MAA42799@harmony.village.org>
X-Mailer: Mew version 1.94 on Emacs 20.4 / Mule 4.0 (HANANOEN)
X-Prom-Mew: Prom-Mew 1.93.4 (procmail reader for Mew)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-Id: <20000324100446A.shin@nd.net.fujitsu.co.jp>
Date: Fri, 24 Mar 2000 10:04:46 +0900
From: Yoshinobu Inoue <shin@nd.net.fujitsu.co.jp>
X-Dispatcher: imput version 990905(IM130)
Lines: 16
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

> :     This problem should now be fixed, it's probably the problem I just fixed
> :     a moment ago in netinet/if_ether.c based on a thread in -hackers.  The
> :     m_pullup() NULL check in arpintr() was broken, resulting in a NULL
> :     pointer dereference.  
> 
> inoue-san's patch survived the night.  I'll check into your patch and
> give it a try instead.

My patch is just a workaround to avoid m_pullup() when it is
not necessary, and his fix seems to be the real one for the
problem.
But I think my patch to if_rl.c is also better to be applied
for performance reason.

Cheers,
Yoshinobu Inoue


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message