From owner-svn-src-head@freebsd.org Fri Feb 5 05:53:44 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 306FAA9A63E; Fri, 5 Feb 2016 05:53:44 +0000 (UTC) (envelope-from sepherosa@gmail.com) Received: from mail-vk0-x22b.google.com (mail-vk0-x22b.google.com [IPv6:2607:f8b0:400c:c05::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DEB28F6; Fri, 5 Feb 2016 05:53:43 +0000 (UTC) (envelope-from sepherosa@gmail.com) Received: by mail-vk0-x22b.google.com with SMTP id c3so4121421vkb.3; Thu, 04 Feb 2016 21:53:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type:content-transfer-encoding; bh=fgMOcdDMU426SnEXSewxu6Rj5bd15epvEQj6/rEsT7c=; b=LcwwCDqul0KZGewN/B8WSKP5FIpH9rfvvOSTUkHqz88X8sOz2jo4418LT9fOA1N/K/ kZbLyvzZHVQRF55I9Z1xtBw5G8j3uA1JnKxhCMiOE+4Ah856+heValY+l7fE6FRZlmoL rH3CpyZL7dGpKyUEN8MSGBABcVTLEetYT4kpmeais5cFogIL4OYciPiefYTzFp5un0Pg b6s9gId/6OLK7pzTlK7DDMFv3fKUbeaFiGNL4594m6plnUbLAZLzJKAhuGLx/BfmEgnd S1ijirQJPDm4GXGvgUg9oV9VAH8LUTH+whMhZzhcd3XdUBAzjM62Sf3OBNnyLRP27Vun x4Kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:date :message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=fgMOcdDMU426SnEXSewxu6Rj5bd15epvEQj6/rEsT7c=; b=HsAD+mpy1+3SchXB7vEtl+ZLlyY5p6YF3hfab2UHfqFqmSb5tPBRIBlESsVfBii7S6 yfRGFA02MKueF5NoIiZJ402qs/MI06QpvEO+jJWtmJPj0J8xwNP4xW10LWM0Bns1ilgj xYJ8OOdU1qnryZ1aviXUeW01b4FgkwBev2+wQni9aFCdmXoNKGQScout6XgGvJmW5CIx Zc6Hoo8qlKwMDUo1T/rh5raQT0fa4ayDIW1kXFybTWXrzDf/WPg5J68l9N6B9/0v8UB4 mRSur4w4DX7r9+td0WXkZKuotXW/SVS7mpsY5HtJmAfMbWvexk1BRnxlSwTwGO8qXObQ GwTA== X-Gm-Message-State: AG10YOTJfTVNiSNvvE3PfoiRaucRBhn8jZq8VCjf64c1hX9BGfUFe6yCgz0Kik9YHk2YHRca0lKteomsetsspA== MIME-Version: 1.0 X-Received: by 10.31.169.87 with SMTP id s84mr8241976vke.55.1454651622982; Thu, 04 Feb 2016 21:53:42 -0800 (PST) Sender: sepherosa@gmail.com Received: by 10.176.65.104 with HTTP; Thu, 4 Feb 2016 21:53:42 -0800 (PST) In-Reply-To: References: <201602050525.u155PBCX071820@repo.freebsd.org> Date: Fri, 5 Feb 2016 13:53:42 +0800 X-Google-Sender-Auth: CRyDa3pBipaEUmaOUt9afpmsOfk Message-ID: Subject: Re: svn commit: r295302 - head/sys/dev/hyperv/netvsc From: Sepherosa Ziehau To: Andriy Voskoboinyk Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Feb 2016 05:53:44 -0000 Oh, thanks, will fix it :) On Fri, Feb 5, 2016 at 1:34 PM, Andriy Voskoboinyk wrote= : > Fri, 05 Feb 2016 07:25:11 +0200 =D0=B1=D1=83=D0=BB=D0=BE =D0=BD=D0=B0=D0= =BF=D0=B8=D1=81=D0=B0=D0=BD=D0=BE Sepherosa Ziehau > : > >> Modified: head/sys/dev/hyperv/netvsc/hv_netvsc_drv_freebsd.c >> >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D >> ... >> @@ -744,31 +745,235 @@ netvsc_channel_rollup(struct hv_device * >> } >> /* >> - * Start a transmit of one or more packets >> + * NOTE: >> + * This this function fails, then both txd and m_head0 will be freed > > > Probably "If this function fails.." ? > > >> */ >> static int >> -hn_start_locked(struct ifnet *ifp, int len) >> +hn_encap(struct hn_softc *sc, struct hn_txdesc *txd, struct mbuf >> **m_head0) >> { --=20 Tomorrow Will Never Die