From owner-freebsd-stable@FreeBSD.ORG Tue Jul 19 13:44:29 2011 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D8FD9106566B; Tue, 19 Jul 2011 13:44:29 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.freebsd.org (Postfix) with ESMTP id 978388FC14; Tue, 19 Jul 2011 13:44:29 +0000 (UTC) Received: from [127.0.0.1] (pooker.samsco.org [168.103.85.57]) (authenticated bits=0) by pooker.samsco.org (8.14.5/8.14.5) with ESMTP id p6JDiOuW033279; Tue, 19 Jul 2011 07:44:24 -0600 (MDT) (envelope-from scottl@samsco.org) Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii From: Scott Long In-Reply-To: <201107190931.36492.jhb@freebsd.org> Date: Tue, 19 Jul 2011 07:44:25 -0600 Content-Transfer-Encoding: quoted-printable Message-Id: <7C636476-7D0A-45C6-8127-A423D9170D0E@samsco.org> References: <4E20BA23.13717.66C6F57@markmcconnell.iinet.com> <201107181714.07827.jhb@freebsd.org> <4F739848-E3CE-4E2C-A91E-90F33410E7AC@samsco.org> <201107190931.36492.jhb@freebsd.org> To: John Baldwin X-Mailer: Apple Mail (2.1084) X-Spam-Status: No, score=-50.0 required=3.8 tests=ALL_TRUSTED, T_RP_MATCHES_RCVD autolearn=unavailable version=3.3.0 X-Spam-Checker-Version: SpamAssassin 3.3.0 (2010-01-18) on pooker.samsco.org Cc: markmc@dataabstractsolutions.com, "freebsd-stable@freebsd.org Stable" Subject: Re: disable 64-bit dma for one PCI slot only? X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Jul 2011 13:44:29 -0000 On Jul 19, 2011, at 7:31 AM, John Baldwin wrote: >>=20 >> If we're going to change it, might as well break it down into 4 = fields. Maybe >> we retain the old format under a legacy switch and/or env variable = for users >> that have tools that parse the output (cough yahoo cough). >=20 > The only reason it might be nice to stick with two fields is due to = the line > length (though the first line is over 80 cols even in the current = format). Here > are two possible suggestions: >=20 I like A for the explicitness, but B is a bit easier to read on an 80 = column display. There's no 'verbose' flag for pciconf, and the '-v' = flag has already been claimed for another use; if a verbose flag were to = appear, I'd suggest hiding the rev and hdr fields under it and otherwise = shortening the line. However, it's not my bikeshed to paint, and I'll = be thrilled with either option A or B or anything in between. > I went with vendor word first for both A) and B) as in my experience = that is > the more common ordering in driver tables, etc. >=20 Indeed. Thanks a lot for working on this. Scott