From nobody Wed Jun 18 02:13:19 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bMS2R453wz5q6c5; Wed, 18 Jun 2025 02:13:19 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bMS2R1Mwkz41Sq; Wed, 18 Jun 2025 02:13:19 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1750212799; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=p/7D7dBfPuck1DDsim5cFGCKMA1vibnqr6AMfKqLg0Y=; b=eZMRHwrpbPSTzQdHW7jhKlctr1aNbABsEJw5lZOymAXFaSwxNP/3nPfkb4qe0rXUtna27W +4n6ONzanfSlPaY//8h8K2JABa+0EqL/ZG5YWfSzkbJ6P4/9ekVGmr+IOlMt5QpltLBjmX eWjsvuWRXLOkpwmdT2nKNKJFHaNFwDhucsBsWKMMPJ3p7ztf1FdbIlggF5lRy5/i8Ty3gZ CGm6mso6c1rJR5Kwebkz/+iBPDte3jOl1LPJrQKarFjkAIdR746GhqY4BWPfsM0XEMaDv0 CrivGssVJdiQjmTwS0mIRGuWNHsUuSXOFV0a9r20ln2WGHKr9bh+7xSHRE1ivw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1750212799; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=p/7D7dBfPuck1DDsim5cFGCKMA1vibnqr6AMfKqLg0Y=; b=E26hsfXoCdZUaGWByK6e/1irkMUvMYSFS8PGqKTYk0BYMA7iwTrfc2OCSkLj4eRekayqfP gMqdikUWzPvyEjSfyhVYVl8FFW5eRnmppp8flDl3ooR5bZ+WN/e157xCErd8OW8SIT2yNW Uf9yL1ttaidINkRcEJl4v3eMC0Qk9dflBERf2PL1BPymrRsn5WiygiBrZ/6kdlC+NV+Ni1 whEfD4HoAX1jpb7PAmg1mpA8G2Uv2pesb+N9R/G4AbK4KOgH2lFdFO3lv7YmAKE5g1/w0v f4/i9fLC3K3nYpdOATbeRmlyutBclDnkSsArWkuLI1tLW7Gww9GNU92RrQTalQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1750212799; a=rsa-sha256; cv=none; b=v9Xt+uQD8Y16N3vKsSYKpddebEDdlGMJ11ll8oI9DPRBCeirLWS8GJGrUHDFZTlxmqhKJ0 8PMYw8PahZwJAW4LkQ/0M1U2oViU74lk87Rk5N/+G2ntaiXgo2xfIUBR/aERv7MjEwR3a1 +Zq1A1suASDlp2iqZsTzThE21GaVNVmge6TkP4Sg1hYOraLY8T5+3QXwuLmCSU6gpM6iSZ OCHBs7kGQldKBuOUylpnNAgIg6POd37/cr6bs8rqcbLZCu14CbmE8PfVi1dxI14RtQjLDB QQQ3eGpu2PpIq59Wg67DlgI5bu9zRAyU0KiHkmlr20v9cSx1Foh1+PZ8n5Z05w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4bMS2R0pBYz18fX; Wed, 18 Jun 2025 02:13:19 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 55I2DJGF024271; Wed, 18 Jun 2025 02:13:19 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 55I2DJJ2024268; Wed, 18 Jun 2025 02:13:19 GMT (envelope-from git) Date: Wed, 18 Jun 2025 02:13:19 GMT Message-Id: <202506180213.55I2DJJ2024268@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Olivier Certner Subject: git: a31193172cb9 - main - runq: New function runq_is_queue_empty(); Use it in ULE List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: olce X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: a31193172cb98bd1fb242555ca8e122efff74258 Auto-Submitted: auto-generated The branch main has been updated by olce: URL: https://cgit.FreeBSD.org/src/commit/?id=a31193172cb98bd1fb242555ca8e122efff74258 commit a31193172cb98bd1fb242555ca8e122efff74258 Author: Olivier Certner AuthorDate: 2024-05-23 15:31:06 +0000 Commit: Olivier Certner CommitDate: 2025-06-18 02:08:00 +0000 runq: New function runq_is_queue_empty(); Use it in ULE Indicates if some particular queue of the runqueue is empty. Reviewed by: kib MFC after: 1 month Event: Kitchener-Waterloo Hackathon 202506 Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D45387 --- sys/kern/kern_switch.c | 28 ++++++++++++++++++++++++++++ sys/kern/sched_ule.c | 2 +- sys/sys/runq.h | 1 + 3 files changed, 30 insertions(+), 1 deletion(-) diff --git a/sys/kern/kern_switch.c b/sys/kern/kern_switch.c index eb39ca88992c..b23dfa162c4f 100644 --- a/sys/kern/kern_switch.c +++ b/sys/kern/kern_switch.c @@ -271,10 +271,13 @@ static inline uintptr_t runq_sw_set_not_empty_op(int idx, int sw_idx, rqsw_t sw_bit, rqsw_t *swp); static inline uintptr_t runq_sw_set_empty_op(int idx, int sw_idx, rqsw_t sw_bit, rqsw_t *swp); +static inline uintptr_t runq_sw_is_empty_op(int idx, int sw_idx, + rqsw_t sw_bit, rqsw_t *swp); /* Status words' individual bit manipulators. */ static inline void runq_sw_set_not_empty(struct runq *rq, int idx); static inline void runq_sw_set_empty(struct runq *rq, int idx); +static inline bool runq_sw_is_empty(struct runq *rq, int idx); /* * Initialize a run structure. @@ -358,6 +361,31 @@ runq_sw_set_empty(struct runq *rq, int idx) (void)runq_sw_apply(rq, idx, &runq_sw_set_empty_op); } +static inline uintptr_t +runq_sw_is_empty_op(int idx, int sw_idx, rqsw_t sw_bit, rqsw_t *swp) +{ + return ((*swp & sw_bit) == 0); +} + +/* + * Returns whether the status words indicate that some queue is empty. + */ +static inline bool +runq_sw_is_empty(struct runq *rq, int idx) +{ + return (runq_sw_apply(rq, idx, &runq_sw_is_empty_op)); +} + +/* + * Returns whether a particular queue is empty. + */ +bool +runq_is_queue_empty(struct runq *rq, int idx) +{ + + return (runq_sw_is_empty(rq, idx)); +} + /* * Add the thread to the queue specified by its priority, and set the * corresponding status bit. diff --git a/sys/kern/sched_ule.c b/sys/kern/sched_ule.c index 1cec38597952..c23d00fd6049 100644 --- a/sys/kern/sched_ule.c +++ b/sys/kern/sched_ule.c @@ -2602,7 +2602,7 @@ sched_clock(struct thread *td, int cnt) */ if (tdq->tdq_idx == tdq->tdq_ridx) { tdq->tdq_idx = (tdq->tdq_idx + 1) % RQ_NQS; - if (TAILQ_EMPTY(&tdq->tdq_timeshare.rq_queues[tdq->tdq_ridx])) + if (runq_is_queue_empty(&tdq->tdq_timeshare, tdq->tdq_ridx)) tdq->tdq_ridx = tdq->tdq_idx; } ts = td_get_sched(td); diff --git a/sys/sys/runq.h b/sys/sys/runq.h index c570dd25503b..5156a7d8c307 100644 --- a/sys/sys/runq.h +++ b/sys/sys/runq.h @@ -98,6 +98,7 @@ struct runq { }; void runq_init(struct runq *); +bool runq_is_queue_empty(struct runq *, int _idx); void runq_add(struct runq *, struct thread *, int _flags); void runq_add_idx(struct runq *, struct thread *, int _idx, int _flags); bool runq_remove(struct runq *, struct thread *);