From owner-freebsd-hackers@FreeBSD.ORG  Mon Nov 27 10:03:27 2006
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
X-Original-To: freebsd-hackers@freebsd.org
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id E5D5D16A47B
	for <freebsd-hackers@freebsd.org>; Mon, 27 Nov 2006 10:03:27 +0000 (UTC)
	(envelope-from earl.lapus@gmail.com)
Received: from nf-out-0910.google.com (nf-out-0910.google.com [64.233.182.185])
	by mx1.FreeBSD.org (Postfix) with ESMTP id D126843D53
	for <freebsd-hackers@freebsd.org>; Mon, 27 Nov 2006 10:02:27 +0000 (GMT)
	(envelope-from earl.lapus@gmail.com)
Received: by nf-out-0910.google.com with SMTP id x37so2054319nfc
	for <freebsd-hackers@freebsd.org>; Mon, 27 Nov 2006 02:03:26 -0800 (PST)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com;
	h=received:message-id:date:from:to:subject:mime-version:content-type:content-transfer-encoding:content-disposition;
	b=ZqG9BvNY2LykeWTuW6T+1qZzLsVH7JVABv9ys0oXXYBQAiFfw3yT4EAfQUZH0C6/bZNoq1qqGdNvIvFhvT4eBEnUZE2uLRh+VzsbUQgAtI1DwmPXHTfx/LUifTroGadmqcr9XUX7tDtUFnDORZT4txLhU/lzUqUZVBqoSgI6qmc=
Received: by 10.78.128.11 with SMTP id a11mr13076311hud.1164621805901;
	Mon, 27 Nov 2006 02:03:25 -0800 (PST)
Received: by 10.78.133.9 with HTTP; Mon, 27 Nov 2006 02:03:25 -0800 (PST)
Message-ID: <604f76120611270203n3d065114vdbe8487cc04357e1@mail.gmail.com>
Date: Mon, 27 Nov 2006 18:03:25 +0800
From: "Earl Lapus" <earl.lapus@gmail.com>
To: freebsd-hackers@freebsd.org
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Subject: pfctl
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 27 Nov 2006 10:03:28 -0000

hi,

I was browsing through some code and stumbled upon this:

...
if ((opts->rtsc_m1 < opts->rtsc_m2 && opts->rtsc_m1 != 0) ||
   (opts->rtsc_m1 < opts->rtsc_m2 && opts->rtsc_m1 != 0) ||
   (opts->rtsc_m1 < opts->rtsc_m2 && opts->rtsc_m1 != 0)) {
   warnx("m1 must be zero for convex curve: %s", pa->qname);
   return (-1);
}
...


would it be safe to change it to:
...
if (opts->rtsc_m1 < opts->rtsc_m2 && opts->rtsc_m1 != 0) {
   warnx("m1 must be zero for convex curve: %s", pa->qname);
   return (-1);
}
...

-OR- is there something between those lines that I'm missing.

The piece of code that I'm referring to is found in
/usr/src/contrtib/pf/pfctl/pfctl_altq.c





-- 
There are seven words in this sentence.