From owner-freebsd-current@FreeBSD.ORG  Thu Feb 19 21:34:15 2009
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 8CDBB106566C
	for <freebsd-current@FreeBSD.org>; Thu, 19 Feb 2009 21:34:15 +0000 (UTC)
	(envelope-from hartzell@alerce.com)
Received: from merlin.alerce.com (merlin.alerce.com [64.62.142.94])
	by mx1.freebsd.org (Postfix) with ESMTP id 713B08FC19
	for <freebsd-current@FreeBSD.org>; Thu, 19 Feb 2009 21:34:15 +0000 (UTC)
	(envelope-from hartzell@alerce.com)
Received: from merlin.alerce.com (localhost [127.0.0.1])
	by merlin.alerce.com (Postfix) with ESMTP id 0F3B533C62;
	Thu, 19 Feb 2009 13:34:15 -0800 (PST)
Received: from merlin.alerce.com (localhost [127.0.0.1])
	by merlin.alerce.com (Postfix) with ESMTP id 8747633C5B;
	Thu, 19 Feb 2009 13:34:14 -0800 (PST)
From: George Hartzell <hartzell@alerce.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <18845.53334.624408.594679@almost.alerce.com>
Date: Thu, 19 Feb 2009 13:34:14 -0800
To: Maxim Sobolev <sobomax@FreeBSD.org>
In-Reply-To: <499DB399.4000604@FreeBSD.org>
References: <18845.41728.753753.864779@almost.alerce.com>
	<499DB399.4000604@FreeBSD.org>
X-Mailer: VM 8.0.12 under 22.1.50.1 (i386-apple-darwin8.11.1)
X-Virus-Scanned: ClamAV using ClamSMTP
X-Mailman-Approved-At: Thu, 19 Feb 2009 22:04:03 +0000
Cc: freebsd-current@FreeBSD.org, hartzell@alerce.com
Subject: Re: help generating good id string for ATA id fix (Via VB8001)
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: hartzell@alerce.com
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 19 Feb 2009 21:34:15 -0000

Maxim Sobolev writes:
 > George Hartzell wrote:
 > > I have a Via VB8001 running -CURRENT.  The disk controllers aren't
 > > recognized and end up running in UDMA33.
 > > 
 > > The following patches to things under /usr/src/sys/dev/ata recognize
 > > my drives as SATA300.
 > > 
 > > I don't know how to figure out what id strings to use though,
 > > everything I've found about the board claims that the chip is a 8237S,
 > > which is already used.  Clearly calling it the GH is a hack.
 > > 
 > > How can I track down the correct info so that I can submit a useful
 > > PR?
 > 
 > Why does it matter so much? Call it ATA_VIA8237S_1 or ATA_VIA8237S_5372 
 > for example, this is definitely not the first time in history when 
 > vendor use different PCI Id for the different silicon revisions of the 
 > same part.

It doesn't matter to me, but for the same reason it's useful to choose
evocative and mnemonic variable name I'd be willing to do a bit of leg
work to actually call it with it's proper name.  The obvious (to me)
googling and such didn't get me anywhere and I'm not sure where to
turn next.

If sos@ or whoever else eventually commits it is happy with
ATA_VIA8237S_1 then I'll move on to other stuff.

g.