From owner-cvs-src@FreeBSD.ORG Fri Feb 4 16:36:29 2005 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3C2F416A4CE for ; Fri, 4 Feb 2005 16:36:29 +0000 (GMT) Received: from mail27.sea5.speakeasy.net (mail27.sea5.speakeasy.net [69.17.117.29]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8F6C343D55 for ; Fri, 4 Feb 2005 16:36:28 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: (qmail 22358 invoked from network); 4 Feb 2005 16:36:28 -0000 Received: from server.baldwin.cx ([216.27.160.63]) (envelope-sender )AES256-SHA encrypted SMTP for ; 4 Feb 2005 16:36:27 -0000 Received: from [10.50.40.202] (gw1.twc.weather.com [216.133.140.1]) (authenticated bits=0) by server.baldwin.cx (8.13.1/8.13.1) with ESMTP id j14GZxVP063186; Fri, 4 Feb 2005 11:36:05 -0500 (EST) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: Nate Lawson Date: Fri, 4 Feb 2005 10:20:22 -0500 User-Agent: KMail/1.6.2 References: <20050204063905.8AE4716A4E9@hub.freebsd.org> <420322CA.3090201@root.org> In-Reply-To: <420322CA.3090201@root.org> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200502041020.23141.jhb@FreeBSD.org> X-Spam-Status: No, score=-102.8 required=4.2 tests=ALL_TRUSTED, USER_IN_WHITELIST autolearn=failed version=3.0.2 X-Spam-Checker-Version: SpamAssassin 3.0.2 (2004-11-16) on server.baldwin.cx cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: Marcel Moolenaar Subject: Re: cvs commit: src/sys/ia64/ia64 machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Feb 2005 16:36:29 -0000 On Friday 04 February 2005 02:22 am, Nate Lawson wrote: > Marcel Moolenaar wrote: > > On Feb 3, 2005, at 11:01 PM, Nate Lawson wrote: > >> Marcel Moolenaar wrote: > >>> marcel 2005-02-04 06:38:58 UTC > >>> FreeBSD src repository > >>> Modified files: > >>> sys/ia64/ia64 machdep.c Log: > >>> Include sys/bus.h before sys/cpu.h. The latter needs device_t. > >>> Revision Changes Path > >>> 1.195 +1 -0 src/sys/ia64/ia64/machdep.c > >> > >> Thanks, I've made similar changes to the other arches too. > > > > No worries. Sorry I didn't had the time to test before committing. > > > > BTW, I still have a link error: > > > > pluto2# make > > linking kernel.debug > > acpi_cpu.o(.text+0x2302): In function `acpi_cpu_startup': > > ../../../dev/acpica/acpi_cpu.c:757: undefined reference to `cpu_devclass' > > acpi_cpu.o(.data+0x1a8): In function `acpi_cpu_probe': > > ./bus_if.h:107: undefined reference to `cpu_devclass' > > *** Error code 1 > > > > Stop in /q/6.x/src/sys/ia64/compile/PLUTO2. > > > > Can it be that you missed a file? > > No, it's something I need to fix one way or the other and had on my todo > list. I'm not sure if my approach is correct -- should different > drivers for the same hardware share the same devclass? I have > legacy::cpu and acpi::cpu sharing the same devclass value since neither > can be attached at the same time. I thought in the past there might be > some advantage to this but can't remember the rationale. > > In any case, until I decide whether to go all the way in doing this for > all archs or falling back to static devclasses, I'll fix it by making > acpi's dc static. They should all share the same devclass if they are going to all use the same name. pcib's devclass is an example. It is shared between all the various host-PCI and PCI-PCI bridge drivers. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org