From owner-svn-src-all@freebsd.org Wed Jan 31 16:57:15 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E125AED6CB4; Wed, 31 Jan 2018 16:57:14 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qt0-x229.google.com (mail-qt0-x229.google.com [IPv6:2607:f8b0:400d:c0d::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 750DE6E95C; Wed, 31 Jan 2018 16:57:14 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-qt0-x229.google.com with SMTP id d8so22708259qtm.0; Wed, 31 Jan 2018 08:57:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=U4d5X5CAd6jY7G0u4XJLOnDJWt6hsjImwcXDOY3cFHE=; b=jmvh/23qRpaM8MFlUevMakQgg6A/0A+crMzOcVIIb94ADb56/ZEHP5UrajkdSxUGcf 7gkMpDi3VXbVa6JkwDfVYRa0jSBiuNbjVdrZ52VAO94kBam4Y+UzmIUyHnSeK820AWR+ WYuFc33y0HkzBFbeuG0w7goAmayxOg+wBt+ZzBzWI3KpvPyk3q9TWSoixigvAUwZWb8E v//rjAMoAGjt9AyE0oJvFKLXDavAZ+gYv0HSP6uliyn60DOFznH2BO708OIvyRPlifxP tIzEyQgsMSNPWqCtmgWsWRGnridc3Jhiylh6r6tePyTcT8/uxzpZZYPYhV5o4II02u2X Lu8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=U4d5X5CAd6jY7G0u4XJLOnDJWt6hsjImwcXDOY3cFHE=; b=HtEClfkMfeZ/9VV3SmE9+kyEK5NZLrIHUeZSLvZlXQakCT4GzeEKFc/8cTSljA1NJl SbWvlET5OZ2laiVo9dg0FQq/tEx51PZZgZW7b/5snDkubnRtRpLv5KQCUn8QEHOWs8z8 PwtQ5gLw+bx+9pZVHztQOq4OZBa1cQMfjyYPpQvrBjCclhWt1hTJwjqfo/CHqzHpaZiX xGZ9mauY6Zry2iOYyHOFfjW2N9FtsKcwF58MLcQg0tdCi3CJ4YQXJizmxc/AeriVJ0OA Eg3TuYn8toCIPGvYprOMVhY5B6DuMSH9Nj+7x7UTEhRmePxFGnh8QGUGOcqG9fHsFaG0 tCYQ== X-Gm-Message-State: AKwxytesraq1ABhj1+mSzfZkyUGXFn4ki8JnmLIm/IG1ec8X0xo3yax8 ubDOuu4pjCBWQBK2q2CxcnRbxw== X-Google-Smtp-Source: AH8x224htIk1E8dQnEGfIzMC6UzO+iO+kA6oujv4zW7DmR0nm6SICMlNy8Kf+QjT2T8Oc0lt/zGL5A== X-Received: by 10.200.22.240 with SMTP id y45mr52169256qtk.216.1517417833665; Wed, 31 Jan 2018 08:57:13 -0800 (PST) Received: from raichu (toroon0560w-lp140-02-70-49-169-112.dsl.bell.ca. [70.49.169.112]) by smtp.gmail.com with ESMTPSA id m70sm11008449qke.7.2018.01.31.08.57.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 31 Jan 2018 08:57:12 -0800 (PST) Sender: Mark Johnston Date: Wed, 31 Jan 2018 11:57:08 -0500 From: Mark Johnston To: Kirk McKusick Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r328383 - head/sbin/fsck_ffs Message-ID: <20180131165708.GA11199@raichu> References: <201801242357.w0ONve5P047566@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201801242357.w0ONve5P047566@repo.freebsd.org> User-Agent: Mutt/1.9.2 (2017-12-15) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Jan 2018 16:57:15 -0000 On Wed, Jan 24, 2018 at 11:57:40PM +0000, Kirk McKusick wrote: > Author: mckusick > Date: Wed Jan 24 23:57:40 2018 > New Revision: 328383 > URL: https://svnweb.freebsd.org/changeset/base/328383 > > Log: > More throughly integrate libufs into fsck_ffs by using its cgput() > routine to write out the cylinder groups rather than recreating the > calculation of the cylinder-group check hash in fsck_ffs. > > No functional change intended. > > Modified: > head/sbin/fsck_ffs/fsck.h > head/sbin/fsck_ffs/fsutil.c > head/sbin/fsck_ffs/gjournal.c > head/sbin/fsck_ffs/setup.c > head/sbin/fsck_ffs/suj.c Hi Kirk, This seems to break recovery of SU+J filesystems after an unclean shutdown. fsck_ffs appears to replay the journal and reports that the filesystem is marked clean, but a subsequent attempt to mount the filesystem rw returns an error. I need to run a full fsck or disable SU journaling in order to recover from a crash without manual intervention in single-user mode.