From owner-p4-projects@FreeBSD.ORG Thu Apr 1 23:23:45 2004 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id C242E16A4D0; Thu, 1 Apr 2004 23:23:44 -0800 (PST) Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7DAAB16A4CE for ; Thu, 1 Apr 2004 23:23:44 -0800 (PST) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7614143D53 for ; Thu, 1 Apr 2004 23:23:44 -0800 (PST) (envelope-from marcel@freebsd.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.10/8.12.10) with ESMTP id i327NiGe098534 for ; Thu, 1 Apr 2004 23:23:44 -0800 (PST) (envelope-from marcel@freebsd.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.12.10/8.12.10/Submit) id i327Niak098531 for perforce@freebsd.org; Thu, 1 Apr 2004 23:23:44 -0800 (PST) (envelope-from marcel@freebsd.org) Date: Thu, 1 Apr 2004 23:23:44 -0800 (PST) Message-Id: <200404020723.i327Niak098531@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to marcel@freebsd.org using -f From: Marcel Moolenaar To: Perforce Change Reviews Subject: PERFORCE change 50170 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Apr 2004 07:23:45 -0000 http://perforce.freebsd.org/chv.cgi?CH=50170 Change 50170 by marcel@marcel_nfs on 2004/04/01 23:22:49 Don't check whether the debug port is also the console. Since we're comparing the package handle, we're getting false positives if the serial device has multiple channels. Affected files ... .. //depot/projects/gdb/sys/dev/uart/uart_cpu_sparc64.c#6 edit Differences ... ==== //depot/projects/gdb/sys/dev/uart/uart_cpu_sparc64.c#6 (text+ko) ==== @@ -121,11 +121,6 @@ return (-1); if (strcmp(buf, "serial") != 0) return (-1); - /* Rudimentary sanity check: the debug port cannot be the console. */ - if (OF_getprop(options, "input-device", buf, sizeof(buf)) == -1) - return (input); - if (OF_finddevice(buf) == input) - return (-1); return (input); }