From owner-freebsd-stable@freebsd.org Mon Feb 19 22:35:02 2018 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A0442F051A8 for ; Mon, 19 Feb 2018 22:35:02 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x236.google.com (mail-io0-x236.google.com [IPv6:2607:f8b0:4001:c06::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 30E95700DC for ; Mon, 19 Feb 2018 22:35:02 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x236.google.com with SMTP id 30so7653163iog.2 for ; Mon, 19 Feb 2018 14:35:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=zFxYM5/1EYUg+Llsgi8MNSsYzQyuvQUn2enfPYPl/vg=; b=WLAebcnLxT0F2MmLkjQhY82NkfeVm9/aKdz6Hb0R4G3//w9cJ9boFQlmdg8bESvVVQ 6DFxhZW0midk0UsRspeh0suRqm/HKQp8pEBCOLT7SspQ9Cvu5spuBCBbA643otJOpMQk 7PdTDnc5+ngWYhTFdbfgEs7aUV2QU1K7KpNweGOOXd+ZG8uUhsJ/TDpkYOSHwPlWNiFP hXXBFzEvnu7cSTQV6O+Wm0S/toY7IqNgY6j6Q02fvM7/V+2hv7bSM/LuO9sdyV1hPzQl XOCCmBbw4lrtgxyfgxmUNVBGK0hHrCcNlclc0Effk0Kuy3VxuVeZp5/DBGNh9VQetF48 3wkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=zFxYM5/1EYUg+Llsgi8MNSsYzQyuvQUn2enfPYPl/vg=; b=gJUKwx+ULMBx7mr4c0fXkqps0wphgxHNxjOxzdiuUeIpZiMmo686v6FiyMRJClg0Dp NkghWsV/kGOmI8ylKpjKg4/mjOaV4mZAqY/xmPqLAC4LlW4G95s9nVFyNAaoUw0amD5R gpd+8j9dlPLULPw6lnm0SS5W1NTx9E97p1gSWHyB1V7Y34PgpRFGrXfPqgVWR92LGH9F irFA5hEWDW9rxnXYF/7NCCR1/B8d1VxRngd2C+jhOp9yQbLX9bGXUaDWPCUkuSUXeY9f U3oNobtNfxBoad7HOH7eKa3jajK0T4BwU4sf+ev22XAIyixBnKMo7NBP0Bm4Zx4JhxVu rkrg== X-Gm-Message-State: APf1xPCH4ZqKFqSvkDnUEqnorOEsmQRPuetWE3soagNolj3iFZN7zOfB 9m9rfP3cgSrqdOUVd1zbiRBnvXAam+6h91hYBq0uQw== X-Google-Smtp-Source: AH8x224Ter1XS9ZYJ5U7olLUp+6oNkgLcST0FDtoB6oxJDOGEzUv9twXSl4JHsvzNgjjoR2CAh30k22aLx/OI3vtkqk= X-Received: by 10.107.180.83 with SMTP id d80mr6804674iof.168.1519079701403; Mon, 19 Feb 2018 14:35:01 -0800 (PST) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.201.67 with HTTP; Mon, 19 Feb 2018 14:35:00 -0800 (PST) X-Originating-IP: [50.253.99.174] In-Reply-To: <20180219092740.GT3353@server.rulingia.com> References: <20180218091204.GR3353@server.rulingia.com> <20180219092740.GT3353@server.rulingia.com> From: Warner Losh Date: Mon, 19 Feb 2018 15:35:00 -0700 X-Google-Sender-Auth: WDMRmkthlHwV709OSVfr_-gUdCc Message-ID: Subject: Re: Problems building 11-stable/i386 with readonly /usr/src To: Peter Jeremy Cc: Kyle Evans , Warner Losh , Bryan Drewery , FreeBSD-STABLE Mailing List Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Feb 2018 22:35:02 -0000 On Mon, Feb 19, 2018 at 2:27 AM, Peter Jeremy wrote: > On 2018-Feb-18 09:06:38 -0600, Kyle Evans wrote: > >On Sun, Feb 18, 2018 at 3:12 AM, Peter Jeremy wrote: > >> Sometime between r329122 and r329157, my 11-stable i386 box stopped > >> being able to buildworld with a readonly /usr/src. I've been updating > >> regularly but the problem still remains at r329450. I don't have any > >> problems building the same tree on amd64 or building head on i386 or > >> amd64. Does anyone have any ideas? > >> > >> Starting from an empty /usr/obj, the failure is: > >> ... > > > >This would have come in with the recent MFC of imp@'s rototilling. I > >seem to recall some build system funkiness that put .OBJDIR inside the > >src tree inconsistently before recent-ish changes in head. CC'ing > >bdrewery@ and imp@ in hopes they have an idea of how to handle this in > >stable/11. The offending ln invocation would be this one: > >https://svnweb.freebsd.org/base/stable/11/stand/defs.mk?view=markup#l178 > > Thanks for that. I added some debug code to stand/defs.mk and confirmed > that in stand/efi, the ${_ILINKS} target is invoked in /usr/src/stand/efi, > whereas in (eg) stand/zfs, it is invoked in /usr/obj/usr/src/stand/efi. > The main difference is that SUBDIR is empty on i386 but non-empty on amd64. > If I add i386 to the main build list (see patch below) then it all works. > I'm not sure why efi isn't built on i386 because boot1, libefi and loader > all support i386. (This obviously is a work-around rather than a real fix > but might be an option if the relevant head changes can't be MFC'd > immediately). > i386 does not support efi at all. We likely shouldn't include efi at all in the subdirs at the top level as a better workaround. Warner > > [Caution: copy and paste, tabs have been converted to spaces] > Index: stand/efi/Makefile > =================================================================== > --- stand/efi/Makefile (revision 329477) > +++ stand/efi/Makefile (working copy) > @@ -14,7 +14,8 @@ > > .if ${MACHINE_CPUARCH} == "aarch64" || \ > ${MACHINE_CPUARCH} == "amd64" || \ > - ${MACHINE_CPUARCH} == "arm" > + ${MACHINE_CPUARCH} == "arm" || \ > + ${MACHINE_CPUARCH} == "i386" > SUBDIR+= libefi loader boot1 > .endif > > -- > Peter Jeremy >