From owner-freebsd-current@FreeBSD.ORG Wed Oct 3 23:42:22 2007 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2C7B616A41B for ; Wed, 3 Oct 2007 23:42:22 +0000 (UTC) (envelope-from rrs@cisco.com) Received: from sj-iport-6.cisco.com (sj-iport-6.cisco.com [171.71.176.117]) by mx1.freebsd.org (Postfix) with ESMTP id DC2C113C4A3 for ; Wed, 3 Oct 2007 23:42:21 +0000 (UTC) (envelope-from rrs@cisco.com) X-IronPort-AV: E=Sophos;i="4.21,226,1188802800"; d="scan'208";a="230050750" Received: from sj-dkim-3.cisco.com ([171.71.179.195]) by sj-iport-6.cisco.com with ESMTP; 03 Oct 2007 16:42:21 -0700 Received: from sj-core-5.cisco.com (sj-core-5.cisco.com [171.71.177.238]) by sj-dkim-3.cisco.com (8.12.11/8.12.11) with ESMTP id l93NgLNG007949; Wed, 3 Oct 2007 16:42:21 -0700 Received: from xbh-sjc-221.amer.cisco.com (xbh-sjc-221.cisco.com [128.107.191.63]) by sj-core-5.cisco.com (8.12.10/8.12.6) with ESMTP id l93Ng2Pk016198; Wed, 3 Oct 2007 23:42:21 GMT Received: from xfe-sjc-212.amer.cisco.com ([171.70.151.187]) by xbh-sjc-221.amer.cisco.com with Microsoft SMTPSVC(6.0.3790.1830); Wed, 3 Oct 2007 16:42:17 -0700 Received: from [128.107.159.252] ([128.107.159.252]) by xfe-sjc-212.amer.cisco.com with Microsoft SMTPSVC(6.0.3790.1830); Wed, 3 Oct 2007 16:42:17 -0700 Message-ID: <470428B0.9070204@cisco.com> Date: Wed, 03 Oct 2007 19:41:36 -0400 From: Randall Stewart User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.13) Gecko/20070601 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Aryeh Friedman References: <20071003141412.GA1311@thunderbird.tld> <47041CE2.60603@cisco.com> In-Reply-To: Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 03 Oct 2007 23:42:17.0575 (UTC) FILETIME=[0871CF70:01C80617] DKIM-Signature: v=0.5; a=rsa-sha256; q=dns/txt; l=1190; t=1191454941; x=1192318941; c=relaxed/simple; s=sjdkim3002; h=Content-Type:From:Subject:Content-Transfer-Encoding:MIME-Version; d=cisco.com; i=rrs@cisco.com; z=From:=20Randall=20Stewart=20 |Subject:=20Re=3A=20[SCTP][patch]=20socket=20does=20not=20wake=20up |Sender:=20; bh=QUx6AZjFtX9LAmdRu1O5fW+SM3+LPA3ORvMq59+Bej8=; b=TpYh+79xajaOUmPKOtWhpz+TdmizgUOBJSu8Aq2FFR1BXH6fOVlT7S6zJWMUnwF9VblK1pjF GAvMHseYOEFzYlza2tF3/9uF+HD/X3/L28hHaG48GsKyoeiCtKLYjiZK; Authentication-Results: sj-dkim-3; header.From=rrs@cisco.com; dkim=pass (sig from cisco.com/sjdkim3002 verified; ); Cc: current@freebsd.org, Martin Kulas Subject: Re: [SCTP][patch] socket does not wake up X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Oct 2007 23:42:22 -0000 Aryeh Friedman wrote: > On 10/3/07, Randall Stewart wrote: > >>Martin: >> >>Thanks for the patch.. note that I will submit it to >>re for approval after a minor fix. >> >>socantrcvmore(so); >> >>assumes you do NOT hold a lock. This code holds >>the socket lock.. which is the recv sockbuf lock.. >> >>So if you turn witness on your kernel and run with this >>you will have a double lock.. panic. >> >>Note to fix this right you should have it be: >> SOCK_UNLOCK(so); >>+ socantrcvmore(so); >> >>Which is what I will submit to release ops.. you may want >>to change this in what you are working with so you don;t >>have some other side-effect issue from the double lock.. like >>leaking sockets. > > > Does this solve the many issues with warning messages and syn/ack > being received after close and such? Also I think this might also be > related to the re(3) patch I mentioned in an other thread > This is SCTP not TCP... so no I don't think it will help any syn-ack problems. R -- Randall Stewart NSSTG - Cisco Systems Inc. 803-345-0369 803-317-4952 (cell)