From owner-svn-src-all@freebsd.org Tue Dec 29 21:35:23 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3910DA55FCF for ; Tue, 29 Dec 2015 21:35:23 +0000 (UTC) (envelope-from oliver.pinter@hardenedbsd.org) Received: from mail-wm0-x231.google.com (mail-wm0-x231.google.com [IPv6:2a00:1450:400c:c09::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id BC79F1242 for ; Tue, 29 Dec 2015 21:35:22 +0000 (UTC) (envelope-from oliver.pinter@hardenedbsd.org) Received: by mail-wm0-x231.google.com with SMTP id b14so28040168wmb.1 for ; Tue, 29 Dec 2015 13:35:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=poDq6psWOTFHrJVg1s4dP53O1uq1c2aNDgunoX4Y1Ts=; b=KGb3l6nw6EVEgOpqMEE1sifaQ76uFJTEtlZD/EhmE6/3YvYMKmtdO67tuQtghUFz9o CW+a4AmDR/J6GCjZM8YRT3o8y3sy/OKyFd2HCr5U1kKsZqiw4XkfCBtwwuKKMX4UPv45 Lrpqjn5PH3BJLjT48/WmYlLtqqK7O57iRqiRx1ZLuAt1zb25ZJZwsasEJ2lD/8WamA0C SupCtTNkSZO7K5yz3k0M6jN/CU05lUeesTTiLmTeVoG1Z0dcJBfq6fngp2eYQx0CTne3 PZ6DKv9XoQy9lM0ZHvjHXKKhkej9gCrHmhkGZXqurb0MQ5veD57YtnuHesyBwd/kcocJ Wqug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=poDq6psWOTFHrJVg1s4dP53O1uq1c2aNDgunoX4Y1Ts=; b=g+D6fNgXbPqaF1H27CcbA6pOM/5K+3JbPVUv/g5WI/yJfkknId3V9D8gZnTtrc4d3M h9XyoPJnbh2tsdvvI4YcnjpcLQpb2rJzvi7b/5/SCH+V2XsFnvLkmI5jLHX9SE6SCL0A AiDF2xgT0cdh392YYcvMsWaQQpXl/3r4ZV8JAlX/EpsfaA09mOzY0ZI1EjOK4KgTjcj5 yB5zKyg7rS5+7N6yivQXzZwKVl9U0TnbKeRFJCR9IYvWwJRs3OnwNgWOEmUlBp0+98Um sXFjYlbrjPvGcrb8umr2mkU3H3KqUgCJotRzrvm4C9lCcsoRcLauQkvI4vVhtyR32iFA akrA== X-Gm-Message-State: ALoCoQkopxzh1hcXaoXmGI+zjZldd11BSNvugQcV9ZbuEB90M1/EtfPNp1w+T/YnEWIR4pJIHqr5mwV3MU4H2ow5R5tMVLzdOocZ++GZO/RF0BoBjBdQM8g= MIME-Version: 1.0 X-Received: by 10.28.171.134 with SMTP id u128mr70122652wme.22.1451424920582; Tue, 29 Dec 2015 13:35:20 -0800 (PST) Received: by 10.194.85.167 with HTTP; Tue, 29 Dec 2015 13:35:20 -0800 (PST) In-Reply-To: <20151229205952.GV7277@FreeBSD.org> References: <201512271442.tBREgdRr079655@repo.freebsd.org> <20151229205952.GV7277@FreeBSD.org> Date: Tue, 29 Dec 2015 22:35:20 +0100 Message-ID: Subject: Re: svn commit: r292772 - head/sys/vm From: Oliver Pinter To: Gleb Smirnoff Cc: Konstantin Belousov , "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" , Shawn Webb Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Dec 2015 21:35:23 -0000 On Tuesday, December 29, 2015, Gleb Smirnoff wrote: > On Sun, Dec 27, 2015 at 02:42:39PM +0000, Konstantin Belousov wrote: > K> Author: kib > K> Date: Sun Dec 27 14:42:39 2015 > K> New Revision: 292772 > K> URL: https://svnweb.freebsd.org/changeset/base/292772 > K> > K> Log: > K> Add missed relpbuf() for a smallfs page-in. > K> > K> Reported by: Shawn Webb > K> Tested by: pho > K> Sponsored by: The FreeBSD Foundation > K> > K> Modified: > K> head/sys/vm/vnode_pager.c > K> > K> Modified: head/sys/vm/vnode_pager.c > K> > ============================================================================== > K> --- head/sys/vm/vnode_pager.c Sun Dec 27 14:39:47 2015 > (r292771) > K> +++ head/sys/vm/vnode_pager.c Sun Dec 27 14:42:39 2015 > (r292772) > K> @@ -806,6 +806,7 @@ vnode_pager_generic_getpages(struct vnod > K> * than a page size, then use special small filesystem code. > K> */ > K> if (pagesperblock == 0) { > K> + relpbuf(bp, freecnt); > K> for (i = 0; i < count; i++) { > K> PCPU_INC(cnt.v_vnodein); > K> PCPU_INC(cnt.v_vnodepgsin); > > The reason for this bug is that I tried to move the (pagesperblock == 0) > block above the call to getpbuf(). > > We actually know that filesystem is "small" at the very beginning of the > function and we can branch into "small filesystem" pager immediately. > > Later I moved the block back to its place, simply because new place > wasn't tested properly. And forgot to restore relpbuf. > > What filesystem did you use to show up the bug? I'm about to test the > variant with immediate branching. Shawn, would you be able to test > a patch if I produce one? > > Isofs, and just take the snapshot from Dec. 17. > -- > Totus tuus, Glebius. > _______________________________________________ > svn-src-head@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/svn-src-head > To unsubscribe, send any mail to "svn-src-head-unsubscribe@freebsd.org > " >