From owner-freebsd-ports@FreeBSD.ORG Thu Feb 7 10:00:08 2013 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 97CBC343 for ; Thu, 7 Feb 2013 10:00:08 +0000 (UTC) (envelope-from freebsd@heesakkers.info) Received: from server4.ohos.nl (server4.ohos.nl [IPv6:2a00:d880:0:6::c951:214d]) by mx1.freebsd.org (Postfix) with ESMTP id 6431E1D2 for ; Thu, 7 Feb 2013 10:00:08 +0000 (UTC) Received: from [2001:470:1f15:1555::2] (helo=pcoliver.heesakkers.info) by server4.ohos.nl with esmtpsa (TLSv1:DHE-RSA-AES256-SHA:256) (Exim 4.80.1) (envelope-from ) id 1U3OGx-0006k6-Dt for freebsd-ports@freebsd.org; Thu, 07 Feb 2013 11:00:06 +0100 From: Oliver Heesakkers To: freebsd-ports@freebsd.org Subject: Re: CFT: building multimedia/vlc with clang on 9.1+ Date: Thu, 07 Feb 2013 11:00:02 +0100 Message-ID: <7957023.xIQB1NoAAJ@pcoliver.heesakkers.info> User-Agent: KMail/4.9.5 (FreeBSD/9.1-RELEASE; KDE/4.9.5; amd64; ; ) In-Reply-To: <20130119210903.GA76282@triton8.kn-bremen.de> References: <20130119210903.GA76282@triton8.kn-bremen.de> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Feb 2013 10:00:08 -0000 Op za 19 jan 2013 22:09:03 schreef Juergen Lock: > Hi! > > As having to depend on gcc 4.6+ on i386 is kindof a waste on 9.1+ > where we have clang too, and clang might generate better code than > the old gcc 4.2.1 in base on amd64 anyway I thought what if we have > the vlc port default to using clang on 9.1+ when it's available? > So I propse the patch below for testing by anyone on 9.1 or later, > also on i386 where I can't test myself, please report any issues > or regressions you find. > I ran into an issue yesterday with an MKV. The error was: "mkv error: cannot find KaxSegment or missing mandatory KaxInfo." Searching this brought me to: http://forum.videolan.org/viewtopic.php?f=13&t=98175 Where the answer is: "Your g++ is to old", they also provide a workaround patch to mkv.hpp that supposedly exposes a security issue: #define MKV_IS_ID( el, C ) ( EbmlId( (*el) ) == C::ClassInfos.GlobalId ) After some quick testing (all FreeBSD 9.1 RELEASE amd64): clang 3.1 without patching: MKV error clang 3.1 with that patch : OK USE_GCC=4.6 without patch : OK Oliver