From owner-svn-src-all@FreeBSD.ORG Sun Dec 8 18:48:07 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id D0FF084D; Sun, 8 Dec 2013 18:48:07 +0000 (UTC) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:1900:2254:2068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id BCE14165B; Sun, 8 Dec 2013 18:48:07 +0000 (UTC) Received: from svn.freebsd.org ([127.0.1.70]) by svn.freebsd.org (8.14.7/8.14.7) with ESMTP id rB8Im7Ls096183; Sun, 8 Dec 2013 18:48:07 GMT (envelope-from dumbbell@svn.freebsd.org) Received: (from dumbbell@localhost) by svn.freebsd.org (8.14.7/8.14.7/Submit) id rB8Im7o7096182; Sun, 8 Dec 2013 18:48:07 GMT (envelope-from dumbbell@svn.freebsd.org) Message-Id: <201312081848.rB8Im7o7096182@svn.freebsd.org> From: Jean-Sebastien Pedron Date: Sun, 8 Dec 2013 18:48:07 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r259104 - head/sys/dev/drm2/radeon X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Dec 2013 18:48:07 -0000 Author: dumbbell Date: Sun Dec 8 18:48:07 2013 New Revision: 259104 URL: http://svnweb.freebsd.org/changeset/base/259104 Log: drm/radeon: radeon_dp_i2c_aux_ch() must return 0 on FreeBSD The code was unmodified compared to Linux and returned the amount of received bytes from the i2c bus. This led to non-working i2c bus and failure to eg. read monitor's EDID, if connected to DisplayPort. MFC after: 3 days Tested by: Mikaƫl Urankar Modified: head/sys/dev/drm2/radeon/atombios_dp.c Modified: head/sys/dev/drm2/radeon/atombios_dp.c ============================================================================== --- head/sys/dev/drm2/radeon/atombios_dp.c Sun Dec 8 17:47:37 2013 (r259103) +++ head/sys/dev/drm2/radeon/atombios_dp.c Sun Dec 8 18:48:07 2013 (r259104) @@ -272,7 +272,7 @@ int radeon_dp_i2c_aux_ch(device_t dev, i case AUX_I2C_REPLY_ACK: if (mode == MODE_I2C_READ) *read_byte = reply[0]; - return ret; + return (0); /* Return ret on Linux. */ case AUX_I2C_REPLY_NACK: DRM_DEBUG_KMS("aux_i2c nack\n"); return -EREMOTEIO;