From owner-svn-ports-all@FreeBSD.ORG Mon May 13 19:23:03 2013 Return-Path: Delivered-To: svn-ports-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 1D926224; Mon, 13 May 2013 19:23:03 +0000 (UTC) (envelope-from lars@e-new.0x20.net) Received: from mail.0x20.net (mail.0x20.net [IPv6:2001:aa8:fffb:1::3]) by mx1.freebsd.org (Postfix) with ESMTP id 72F2E36E; Mon, 13 May 2013 19:23:02 +0000 (UTC) Received: from e-new.0x20.net (mail.0x20.net [IPv6:2001:aa8:fffb:1::3]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.0x20.net (Postfix) with ESMTPS id A4AB46A6000; Mon, 13 May 2013 21:22:59 +0200 (CEST) Received: from e-new.0x20.net (localhost [127.0.0.1]) by e-new.0x20.net (8.14.5/8.14.5) with ESMTP id r4DJMxpw077754; Mon, 13 May 2013 21:22:59 +0200 (CEST) (envelope-from lars@e-new.0x20.net) Received: (from lars@localhost) by e-new.0x20.net (8.14.5/8.14.5/Submit) id r4DJMx9h077495; Mon, 13 May 2013 21:22:59 +0200 (CEST) (envelope-from lars) Date: Mon, 13 May 2013 21:22:59 +0200 From: Lars Engels To: Alexey Dokuchaev Subject: Re: svn commit: r317834 - head/astro/swe Message-ID: <20130513192259.GB32935@e-new.0x20.net> References: <201305101828.r4AISZWi094449@svn.freebsd.org> <20130511091807.GA67148@FreeBSD.org> <20130511095605.GV32935@e-new.0x20.net> <20130511110110.GA92017@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Nm48CqPeykZpOG4/" Content-Disposition: inline In-Reply-To: <20130511110110.GA92017@FreeBSD.org> X-Editor: VIM - Vi IMproved 7.3 X-Operation-System: FreeBSD 8.3-RELEASE-p5 User-Agent: Mutt/1.5.21 (2010-09-15) Cc: Lars Engels , svn-ports-head@FreeBSD.org, svn-ports-all@FreeBSD.org, ports-committers@FreeBSD.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 May 2013 19:23:03 -0000 --Nm48CqPeykZpOG4/ Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, May 11, 2013 at 11:01:10AM +0000, Alexey Dokuchaev wrote: > On Sat, May 11, 2013 at 11:56:05AM +0200, Lars Engels wrote: > > On Sat, May 11, 2013 at 09:18:07AM +0000, Alexey Dokuchaev wrote: > > > On Fri, May 10, 2013 at 06:28:35PM +0000, Lars Engels wrote: > > > > New Revision: 317834 > > > > URL: http://svnweb.freebsd.org/changeset/ports/317834 > > > >=20 > > > > @@ -24,6 +24,10 @@ post-patch: > > > > -e 's|CFLAGS =3D|CFLAGS ?=3D|' \ > > > > ${WRKSRC}/Makefile > > > > =20 > > > > +.if ${OSVERSION} >=3D 100000 > > > > + @${REINPLACE_CMD} -e 's|-O9|-O3|' ${WRKSRC}/Makefile > > > > +.endif > > >=20 > > > Any reason for this fix being conditional on OSVERSION? > >=20 > > I assumed that -O9 didn't work with CLANG on current, but I just checked > > this and the port gets automatically build with -O2. > > I'll talk about it with the PR submitter if it's necessary. >=20 > It would be awesome if the port could be teached to uphold our CFLAGS > instead of using hardcoded (very bogus) -O9 or whatever. >=20 Yes, you're right. The maintainer approved the removal of the conditional and in the post-patch section there's already the patch to use our CFLAGS. --Nm48CqPeykZpOG4/ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlGRPZMACgkQKc512sD3afg5lACeMCeMx+gE17vXbGj7JJP+743n NAUAn0kEMNBjkjV5tROmC2KWxqkfbYza =D8Sh -----END PGP SIGNATURE----- --Nm48CqPeykZpOG4/--