From owner-freebsd-ports-bugs@FreeBSD.ORG Wed May 9 05:00:27 2012 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 9EAAD106566C for ; Wed, 9 May 2012 05:00:27 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 66D318FC0C for ; Wed, 9 May 2012 05:00:27 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q4950RV0091166 for ; Wed, 9 May 2012 05:00:27 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q4950Rsi091165; Wed, 9 May 2012 05:00:27 GMT (envelope-from gnats) Resent-Date: Wed, 9 May 2012 05:00:27 GMT Resent-Message-Id: <201205090500.q4950Rsi091165@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, "Ronald F.Guilmette" Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 624A7106564A for ; Wed, 9 May 2012 04:59:19 +0000 (UTC) (envelope-from rfg@tristatelogic.com) Received: from outgoing.tristatelogic.com (segfault.tristatelogic.com [69.62.255.118]) by mx1.freebsd.org (Postfix) with ESMTP id 3D5CA8FC16 for ; Wed, 9 May 2012 04:59:19 +0000 (UTC) Received: by segfault.tristatelogic.com (Postfix, from userid 1237) id C978D5081B; Tue, 8 May 2012 21:59:18 -0700 (PDT) Message-Id: <20120509045918.C978D5081B@segfault.tristatelogic.com> Date: Tue, 8 May 2012 21:59:18 -0700 (PDT) From: "Ronald F.Guilmette" To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: ports/167726: FreeBSD patch for gthumb-2.14.1_1 is just plain wrong X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: "Ronald F.Guilmette" List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 May 2012 05:00:27 -0000 >Number: 167726 >Category: ports >Synopsis: FreeBSD patch for gthumb-2.14.1_1 is just plain wrong >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed May 09 05:00:27 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Ronald F. Guilmette >Release: FreeBSD 8.3-RELEASE amd64 >Organization: entropy >Environment: System: FreeBSD segfault.tristatelogic.com 8.3-RELEASE FreeBSD 8.3-RELEASE #0: Mon Apr 9 21:23:18 UTC 2012 root@mason.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC amd64 >Description: There is file currently present in the ports tree called: /usr/ports/graphics/gthumb/files/patch-glib-utils.c This patch (or something like it) is indeed necessary in order to make gthumb-2.14.x build successfully. However the patch itself is quite self-evidently wrong. It causes `offset' to always be set to zero, to no apparently useful effect (since the value gets re-set to the value of tm->tm_gmtoff just two lines further down in the code) and also, the patch in question fails to make allowances for possible host systems where neither HAVE_TM_GMTOFF nor HAVE_TIMEZONE are defined. A more correct patch for gthumb-2.14.x is provided below. >How-To-Repeat: cd /usr/ports/graphics/gthumb make >Fix: diff -rc2 gthumb/glib-utils.c gthumb/glib-utils.c *** gthumb/glib-utils.c 2012-03-24 09:28:46.000000000 -0700 --- gthumb/glib-utils.c 2012-05-05 18:48:21.000000000 -0700 *************** *** 553,560 **** int offset; - offset = -timezone; #if defined (HAVE_TM_GMTOFF) offset = tm->tm_gmtoff; #elif defined (HAVE_TIMEZONE) if (tm->tm_isdst > 0) { #if defined (HAVE_ALTZONE) --- 553,560 ---- int offset; #if defined (HAVE_TM_GMTOFF) offset = tm->tm_gmtoff; #elif defined (HAVE_TIMEZONE) + offset = -timezone; if (tm->tm_isdst > 0) { #if defined (HAVE_ALTZONE) *************** *** 565,568 **** --- 565,570 ---- } else offset = -timezone; + #else + offset = 0; #endif >Release-Note: >Audit-Trail: >Unformatted: